Skip to content

Update the EQ in abnormalLevelOfChemicalEntity#982

Open
rays22 wants to merge 2 commits intomasterfrom
issue981
Open

Update the EQ in abnormalLevelOfChemicalEntity#982
rays22 wants to merge 2 commits intomasterfrom
issue981

Conversation

@rays22
Copy link
Copy Markdown
Contributor

@rays22 rays22 commented Apr 14, 2025

This commit intends to restrict the scope of the abnormalLevelOfChemicalEntity pattern to apply to chemical qualities only in anatomical entities. To achieve this, the logical definition will be updated.

If applied, this commit will fix #981.

This commit intends to restrict the scope of the abnormalLevelOfChemicalEntity pattern to apply to chemical qualities only in anatomical entities. To achieve this, the logical definition will be updated.

If applied, this commit will fix #981.
@rays22 rays22 self-assigned this Apr 14, 2025
@rays22 rays22 requested a review from matentzn April 14, 2025 15:10
Copy link
Copy Markdown
Contributor

@sbello sbello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matentzn
Copy link
Copy Markdown
Collaborator

These changes make this identical to http://purl.obolibrary.org/obo/upheno/patterns/abnormalLevelOfChemicalEntityInLocation.yaml

No, not identical - there is no filler class in this pattern! Only the chemical entity and the fact that it is measured in some part of an organism (anatomical entity)

@sbello
Copy link
Copy Markdown
Contributor

sbello commented Apr 14, 2025

Ah, okay. This needs to be made very clear, maybe add a note to the top.
I still have the question of what this means for phenotypes related to levels in exhaled gases. But I think we could probably just leave these without eqs.

Copy link
Copy Markdown
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is correct about this PR but I am scared that if I merge it, I lose a lot of cross species mappings..

  • This this pattern with a uPheno build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restrict the abnormalLevelOfChemicalEntity pattern to anatomical entities

3 participants