-
Notifications
You must be signed in to change notification settings - Fork 0
Add test-runner config to inject __test global for Storybook smoke tests #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hotlong
merged 5 commits into
copilot/update-crm-app-to-msw-mode
from
copilot/fix-action-job-error
Jan 29, 2026
Merged
Add test-runner config to inject __test global for Storybook smoke tests #262
hotlong
merged 5 commits into
copilot/update-crm-app-to-msw-mode
from
copilot/fix-action-job-error
Jan 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix action job error in CI pipeline
Add test-runner config to inject __test global for Storybook smoke tests
Jan 29, 2026
eec1662
into
copilot/update-crm-app-to-msw-mode
7 of 9 checks passed
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a Storybook test-runner configuration to prevent CI failures caused by an expected (but previously undefined) __test global in the Playwright browser context.
Changes:
- Introduce
.storybook/test-runner.tswith apreVisithook that setswindow.__test = truebefore each story visit - Add a TypeScript
Windowinterface augmentation for type-safe access towindow.__test
|
✅ All checks passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Storybook test-runner failing on 11 stories with
ReferenceError: __test is not definedduringpage.evaluate()in smoke tests. Affectedform_extras.stories.tsx(Toggle, ToggleGroup, etc.) andobject-grid.stories.tsx(WithActions).Changes
Created
.storybook/test-runner.tsto injectwindow.__testinto Playwright's browser context before each story visit:The test-runner's internal evaluation code expects this global to exist but doesn't provide it by default.
Reference
https://github.com/objectstack-ai/objectui/actions/runs/21475614104/job/61858765955#step:7:1
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.