Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

Build was failing with TypeScript errors in components and plugin-aggrid packages, plus Next.js prerendering errors on sidebar documentation page.

Changes

  • Unused parameters (TS6133): Removed unused rest parameters in SimpleTableRenderer and PlaceholderRenderer destructuring patterns

  • AG Grid type conflicts (TS2322, TS2769):

    • Aligned ag-grid-community and ag-grid-react to matching v32.3.9 (was v35.0.1 and v32.3.4)
    • Removed explicit GridOptions type annotation in mergedGridOptions to allow inference
  • Sidebar prerendering: Wrapped all MDX demo schemas with sidebar-provider component. The Sidebar component uses useSidebar() hook which requires context:

// Before (missing provider)
<ComponentDemo schema={{ type: 'sidebar', items: [...] }} />

// After (with required provider)
<ComponentDemo schema={{
  type: 'sidebar-provider',
  body: [
    { type: 'sidebar', body: [...] },
    { type: 'sidebar-inset', body: [...] }
  ]
}} />

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/objectui/objectui/apps/site/node_modules/.bin/../next/dist/bin/next build git e/no�� get --global ponents/node_modules/.bin/vite pull.rebase (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

拉取请求: #234

18:53:11.685 ../../packages/components build: �[96msrc/renderers/data-display/table.tsx�[0m:�[93m22�[0m:�[93m61�[0m - �[91merror�[0m�[90m TS6133: �[0m'_props' is declared but its value is never read.
18:53:11.686 ../../packages/components build: �[96msrc/renderers/placeholders.tsx�[0m:�[93m14�[0m:�[93m61�[0m - �[91merror�[0m�[90m TS6133: �[0m'props' is declared but its value is never read.
18:53:23.379 ../../packages/plugin-aggrid build: �[96msrc/AgGridImpl.tsx�[0m:�[93m226�[0m:�[93m9�[0m - �[91merror�[0m�[90m TS2322: �[0mType '{ pagination: boolean; paginationPageSize: number; domLayout: "normal" | "autoHeight" | "print"; animateRows: boolean; rowSelection: "single" | "multiple" | undefined; editType: "fullRow" | undefined; ... 437 more ...; onSortChanged?(event: SortChangedEvent<...>): void; }' is not assignable to type 'GridOptions'.
18:53:23.382 ../../packages/plugin-aggrid build: �[96msrc/AgGridImpl.tsx�[0m:�[93m307�[0m:�[93m10�[0m - �[91merror�[0m�[90m TS2769: �[0mNo overload matches this call.
18:54:37.564 Error occurred prerendering page "/docs/components/basic/sidebar". Read more: https://nextjs.org/docs/messages/prerender-error
18:54:37.567 Error: useSidebar must be used within a SidebarProvider.
18:54:37.568 at Tt (.next/server/chunks/ssr/3f0f8b0f..js:77:57878)
18:54:37.568 at Tv (.next/server/chunks/ssr/3f0f8b0f..js:77:59328) {
18:54:37.568 digest: '2237064002'
18:54:37.568 }
18:54:37.569 Export encountered an error on /docs/[[...slug]]/page: /docs/components/basic/sidebar, exiting the build.
18:54:37.720  ELIFECYCLE  Command failed with exit code 1.
18:54:37.752 Error: Command "pnpm --filter '../../packages/*' -r build && pnpm build" exited with 1


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
objectui-site Error Error Jan 27, 2026 11:07am

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix unused props declaration errors in components Fix build failures: unused parameters, AG Grid type conflicts, and sidebar prerendering Jan 27, 2026
Copilot AI requested a review from hotlong January 27, 2026 11:07
@hotlong hotlong marked this pull request as ready for review January 27, 2026 11:12
Copilot AI review requested due to automatic review settings January 27, 2026 11:12
@hotlong hotlong merged commit 73a236e into copilot/fix-loading-issue-docs Jan 27, 2026
5 of 6 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes three categories of build failures: TypeScript compilation errors for unused parameters, AG Grid type conflicts from mismatched package versions, and Next.js prerendering errors in sidebar documentation.

Changes:

  • Removed unused rest parameters from component destructuring patterns to fix TS6133 errors
  • Aligned AG Grid packages to matching v32.3.9 versions and removed explicit type annotation to resolve type conflicts
  • Wrapped all sidebar MDX demo schemas with sidebar-provider component to provide required React context for the useSidebar() hook

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Updated ag-grid-community and ag-grid-react to matching v32.3.9, removed unused ag-charts-types@13.0.1
packages/plugin-aggrid/package.json Aligned ag-grid-community (^35.0.1 → ^32.3.9) and ag-grid-react (^32.3.4 → ^32.3.9)
packages/plugin-aggrid/src/AgGridImpl.tsx Removed explicit GridOptions type annotation to allow inference and resolve type conflicts
packages/components/src/renderers/placeholders.tsx Removed unused props rest parameter from destructuring
packages/components/src/renderers/data-display/table.tsx Removed unused _props rest parameter from destructuring
content/docs/components/basic/sidebar.mdx Wrapped all sidebar demo schemas with sidebar-provider and converted to compositional structure using nested sidebar components
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants