-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor formula engine and validator into separate plugin packages #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Created @objectql/plugin-formula package with FormulaEngine and FormulaPlugin - Created @objectql/plugin-validator package with Validator and ValidatorPlugin - Updated @objectql/core to depend on and re-export from new plugins - Moved all source files and tests to appropriate plugin packages - Updated imports throughout the codebase - All packages build successfully Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
…ixes - Fixed test imports and added mock-driver to plugin test directories - Created comprehensive MIGRATION_GUIDE.md - Fixed code formatting issues identified in review - All 282 tests passing (109 formula, 52 validator, 121 core) - CodeQL security scan passed with no alerts - Backward compatibility maintained through core package re-exports Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
|
不需要Re-exports components for backward compatibility @copilot |
Per feedback, the @objectql/core package no longer re-exports components from
plugin-formula and plugin-validator. Users must now explicitly import from the
plugin packages they use, enforcing clean separation of concerns.
Breaking change: Applications must update imports:
- Before: import { FormulaEngine, Validator } from '@objectql/core';
- After: import { FormulaEngine } from '@objectql/plugin-formula';
import { Validator } from '@objectql/plugin-validator';
Updated MIGRATION_GUIDE.md and PLUGIN_REFACTORING_SUMMARY.md to reflect
this change and remove references to backward compatibility.
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Done. Removed backward compatibility re-exports from @objectql/core. Users must now explicitly import from @objectql/plugin-formula and @objectql/plugin-validator. This enforces clean separation of concerns. Updated documentation (MIGRATION_GUIDE.md and PLUGIN_REFACTORING_SUMMARY.md) to reflect this breaking change. All 282 tests still passing. Commit: 73822a4 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
- Add plugin-validator and plugin-formula to root tsconfig references - Update core package tsconfig to reference plugin packages - Fix CLI import to use plugin-validator directly - Add plugin-validator dependency to CLI package Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
|
Extracted formula engine and validator from monolithic
@objectql/coreinto dedicated plugins, improving modularity and bundle size with clean separation of concerns.Changes
New Packages
Core Package Updates
Migration Path
Breaking Change: Applications must update imports to use dedicated packages:
Architecture
Before:
After:
Follows existing pattern from
@objectql/plugin-security. Enables tree-shaking and optional feature inclusion. Enforces clean architectural boundaries with explicit dependencies.Testing
Documentation
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.