Skip to content

fix: google API key #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
christianruhstaller wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: google API key #65

christianruhstaller wants to merge 4 commits into from

Conversation

@christianruhstaller
Copy link

@christianruhstaller christianruhstaller commented Jul 1, 2016

No description provided.

@christianruhstaller christianruhstaller mentioned this pull request Jul 1, 2016
Open
@gijsstegehuis
Copy link

gijsstegehuis commented Apr 4, 2017

This fix is not complete as its missing one API key reference:

Google-Maps-for-Craft/fieldtypes/GoogleMaps_AddressFieldType.php

Line 72 in a054d9d

craft()->templates->includeJsFile('//maps.googleapis.com/maps/api/js?key=&sensor=false&callback=GoogleMaps.init');

@christianruhstaller
Copy link
Author

christianruhstaller commented Apr 4, 2017

See: christianruhstaller@8973f5d

@gijsstegehuis
Copy link

gijsstegehuis commented Apr 5, 2017

@christianruhstaller can you please bump the version for this fix?

@christianruhstaller
Copy link
Author

christianruhstaller commented Apr 5, 2017

https://github.com/christianruhstaller/Google-Maps-for-Craft/releases/tag/0.9.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christianruhstaller @gijsstegehuis