Skip to content

#257: replace sync-request with curl#950

Open
nacNAC333 wants to merge 1 commit into
objectionary:masterfrom
nacNAC333:257
Open

#257: replace sync-request with curl#950
nacNAC333 wants to merge 1 commit into
objectionary:masterfrom
nacNAC333:257

Conversation

@nacNAC333
Copy link
Copy Markdown

Fixes #257

Replaces the sync-request npm package with curl via child_process.execSync for fetching Maven Central metadata.

sync-request pulls in a large transitive dependency tree and has known issues with newer Node versions. curl is universally available on all supported platforms (macOS, Linux, Windows via PowerShell).

Changes:

  • Rewrite parser-version.js to use execSync("curl ...") instead of sync-request
  • Remove sync-request from package.json dependencies
  • Add exists() method for version validation using HTTP HEAD check

@yegor256
Copy link
Copy Markdown
Member

@nacNAC333 Thanks for your contribution, we appreciate it! Before we can merge this pull request, we need to see all CI workflows pass without errors. We can't merge the pull request into the master branch unless all workflows are green. Try to fix them, also paying attention to code style issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--latest implementation is not Maven-native

2 participants