#257: replace sync-request with curl#950
Open
nacNAC333 wants to merge 1 commit into
Open
Conversation
Member
|
@nacNAC333 Thanks for your contribution, we appreciate it! Before we can merge this pull request, we need to see all CI workflows pass without errors. We can't merge the pull request into the master branch unless all workflows are green. Try to fix them, also paying attention to code style issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #257
Replaces the
sync-requestnpm package withcurlviachild_process.execSyncfor fetching Maven Central metadata.sync-requestpulls in a large transitive dependency tree and has known issues with newer Node versions.curlis universally available on all supported platforms (macOS, Linux, Windows via PowerShell).Changes:
parser-version.jsto useexecSync("curl ...")instead ofsync-requestsync-requestfrompackage.jsondependenciesexists()method for version validation using HTTP HEAD check