#939: drop dead postinstall.js and stale patch#949
Open
nacNAC333 wants to merge 1 commit into
Open
Conversation
…ckage dep The `grunt-mocha-cli` devDependency was replaced by `grunt-mocha-test` in objectionary#892, but `scripts/postinstall.js` still checked for `node_modules/grunt-mocha-cli` to decide whether to run `patch-package`. That check was always false, so the Windows shell-fix patch in `patches/grunt-mocha-cli+7.0.0.patch` was never applied. `grunt-mocha-test` runs mocha in-process and does not need the patch. Removed: - `scripts/postinstall.js` (dead conditional logic) - `patches/grunt-mocha-cli+7.0.0.patch` (targets absent package) - `patch-package` devDependency (no remaining patches) - `postinstall` npm script entry
nacNAC333
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
grunt-mocha-clidevDependency was replaced bygrunt-mocha-testin #892, but
scripts/postinstall.jsstill checked fornode_modules/grunt-mocha-clito decide whether to runpatch-package. That check was always false, so the Windowsshell-fix patch in
patches/grunt-mocha-cli+7.0.0.patchwasnever applied.
grunt-mocha-testruns mocha in-process anddoes not need the patch.
Removed:
scripts/postinstall.js(dead conditional logic)patches/grunt-mocha-cli+7.0.0.patch(targets absent package)patch-packagedevDependency (no remaining patches)postinstallnpm script entryCloses #939.