Remove automatic java plugin application for Android compatibility #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the automatic application of the
javaplugin from the Decycle Gradle plugin, making it compatible with Android projects while maintaining full backwards compatibility for Java projects.Problem
The Decycle plugin automatically applied the
javaplugin, which conflicts with Android plugins that provide their own source set management. This prevented Android developers from using Decycle for cycle detection in their projects.Solution
project.apply plugin: 'java'automaticallyjavaplugin in test configurationsChanges Made
project.apply plugin: 'java'fromDecyclePlugin.groovyafterEvaluateblock to check forsourceSetsproperty*.gradleand*.gradle.ktsfiles to explicitly apply java pluginTesting
Usage
Before (Java projects only):
After (Java and Android projects):
This is a minimal, surgical change that solves the Android compatibility issue without breaking existing functionality.
Fixes #49.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
docs.oracle.com/usr/lib/jvm/temurin-11-jdk-amd64/bin/javadoc @/home/REDACTED/work/decycle/decycle/lib/build/tmp/javadoc/javadoc.options(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.