feat: format known addresses for consensus txes#2335
Merged
uniyalabhishek merged 1 commit intomainfrom Feb 4, 2026
Merged
Conversation
uniyalabhishek
requested review from
kostko,
peternose,
pro-wh and
ptrus
as code owners
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
peternose
reviewed
Sep 21, 2025
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
c6e493b to
368a2f8
Compare
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
368a2f8 to
39dc9d7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2335 +/- ##
==========================================
+ Coverage 48.55% 48.64% +0.09%
==========================================
Files 224 224
Lines 16079 16104 +25
==========================================
+ Hits 7807 7834 +27
+ Misses 8212 8210 -2
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
50f62d5 to
a5339d0
Compare
uniyalabhishek
requested review from
matevz and
peternose
and removed request for
pro-wh
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
a5339d0 to
555737b
Compare
matevz
reviewed
Jan 28, 2026
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
15eed1f to
b4fc6b9
Compare
matevz
reviewed
Feb 2, 2026
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
3f5fda1 to
dd454cf
Compare
matevz
approved these changes
Feb 3, 2026
Member
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
I think this is good to go now.
test: cover consensusaccounts.Undelegate PrettyPrint feat: preserve user-provided eth addresses refactor: update address formatting for unnamed Ethereum addresses
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
d8604c9 to
f437f1d
Compare
ptrus
approved these changes
Feb 4, 2026
uniyalabhishek
deleted the
uniyalabhishek/feature/format-known-addresses-131
branch
github-actions Bot
added a commit
that referenced
this pull request
Feb 4, 2026
…niyalabhishek/feature/format-known-addresses-131 feat: format known addresses for consensus txes 6b659c9
github-actions Bot
added a commit
that referenced
this pull request
Feb 4, 2026
…/uniyalabhishek/feature/format-known-addresses-131 feat: format known addresses for consensus txes 6b659c9
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Feb 4, 2026
…sisprotocol/uniyalabhishek/feature/format-known-addresses-131 feat: format known addresses for consensus txes 6b659c9
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Feb 4, 2026
…oasisprotocol/uniyalabhishek/feature/format-known-addresses-131 feat: format known addresses for consensus txes 6b659c9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a small, reusable address-formatting primitive to the Go client SDK so downstream tools (incl. oasis CLI) can consistently render “known” accounts.
types.ContextKeyAccountEthMap+types.FormatNamedAddress{,With}to format addresses asname (preferred-address), preferring Ethereum hex when available for the native address.PrettyPrintToAmount,consensusaccounts.Undelegate.PrettyPrint) so consensus/runtime tx output can show names instead of raw addresses when a caller provides name/eth maps incontext.Context.PR oasisprotocol/cli#616 is dependent on this.