Skip to content

Fix some v21/test_observed_data.py unit test breakage #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpiazza merged 1 commit into from
Apr 24, 2025
+7 −7
Merged

Fix some v21/test_observed_data.py unit test breakage #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions stix2/test/v21/test_observed_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,9 +1108,9 @@ def test_network_traffic_http_request_example():
request_value="/download.html",
request_version="http/1.1",
request_header={
"Accept-Encoding": "gzip,deflate",
"User-Agent": "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113",
"Host": "www.example.com",
"Accept-Encoding": ["gzip,deflate"],
"User-Agent": ["Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113"],
"Host": ["www.example.com"],
},
)
nt = stix2.v21.NetworkTraffic(
Expand All @@ -1121,9 +1121,9 @@ def test_network_traffic_http_request_example():
assert nt.extensions['http-request-ext'].request_method == "get"
assert nt.extensions['http-request-ext'].request_value == "/download.html"
assert nt.extensions['http-request-ext'].request_version == "http/1.1"
assert nt.extensions['http-request-ext'].request_header['Accept-Encoding'] == "gzip,deflate"
assert nt.extensions['http-request-ext'].request_header['User-Agent'] == "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113"
assert nt.extensions['http-request-ext'].request_header['Host'] == "www.example.com"
assert nt.extensions['http-request-ext'].request_header['Accept-Encoding'] == ["gzip,deflate"]
assert nt.extensions['http-request-ext'].request_header['User-Agent'] == ["Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113"]
assert nt.extensions['http-request-ext'].request_header['Host'] == ["www.example.com"]


def test_network_traffic_icmp_example():
Expand Down Expand Up @@ -1183,7 +1183,7 @@ def test_incorrect_socket_options():
socket_type="SOCK_STREAM",
options={"SO_RCVTIMEO": '100'},
)
assert "Dictionary Property does not support this value's type" in str(excinfo.value)
assert "Invalid value for SocketExt 'options': Invalid value: '100'" in str(excinfo.value)


def test_network_traffic_tcp_example():
Expand Down
Loading