refactor: migrate error to a method parameter, not part of ErrorHandlerOpts
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndlerOpts` While writing the documentation for this, it didn't feel quite right to note that the `error` wasn't part of the method signature, despite it being very important for the actual handling of errors.
jamietanna
force-pushed
the
refactor/method
branch
from
576de1e to
7a9ed14
Compare
jamietanna
changed the title
error to a method parameter, not part of ErrorHandlerOptserror to a method parameter, not part of ErrorHandlerOpts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing the documentation for this, it didn't feel quite right to
note that the
errorwasn't part of the method signature, despite itbeing very important for the actual handling of errors.