Treat computed space better in embark--display-string#809
Open
minad wants to merge 1 commit into
Open
Conversation
See also minad/vertico@14cc82f It would be good to keep these in sync.
Owner
|
I'm a little confused about why this affects embark collect, it uses tabulated-list for alignment. Isn't that different enough from Vertico (which, if I recall, has to assemble the entire candidate line) that it wouldn't be an issue here? Is there a simple completing-read call for which embark-collect shows the problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also minad/vertico@14cc82f
It would be good to keep these in sync.
@oantolin I found this when working with computed space in Elfeed buffers. The problem is that align-to is relative to the left border by default, and since the candidates obtained by consult-line are reformatted with line numbers in front, the align-to space might collapse to a zero width space. Vertico and the Embark snapshot buffer are affected by this. Therefore always add a single space to make sure that the candidates do not look compressed. Compute space with :width does not have that problem. See emacs-elfeed/elfeed@b92434b for reference.
I believe I had such zero space compression in other buffers with alignment before, when invoking consult-line. But I don't remember which mode was affected. So it seems good to do this, even if it is a bit of a hack.