Skip to content

Conversation

@hongchaodeng
Copy link
Member

@hongchaodeng hongchaodeng commented Sep 6, 2019

@wonderflow
Copy link
Member

LGTM

Copy link
Contributor

@mikkelhegn mikkelhegn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should resolve the two new issue I raised before merging this (at least we get things sorted out as we move along :-))

Will see if I can submit these today...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest the example property be something different, to show it's configuring the application scope (all depending on the applicationScope capabilities)

I know this https://github.com/microsoft/hydra-spec/blob/master/4.application_scopes.md#network-scope is mentioning a networkName, but that's a bit weird as we now have a name as part of the spec and a parameter, so we should og back and get the core network scope fixed as well (will raise an issue)

properties:
   - name: ingressVisibility
     value: true
   - name: subnetName
     value: "[fromVariable(subnet-name)]"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed by #140

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's yet to be defined how this should look: https://github.com/microsoft/hydra-spec/blob/master/6.operational_configuration.md#component - I've seen both just a name reference, but also a type. I suggest we assume this will be similar to Traits: https://github.com/microsoft/hydra-spec/blob/master/6.operational_configuration.md#trait

      applicationScopes: 
        - name: testNetworkScope2
          type: core.hydra.io/v1alpha1.Network

issue: https://github.com/microsoft/hydra-spec/issues/130 to specifically track this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a name with a type is OK, though it's even impossible for two app scopes to use same name in real user cases

@mikkelhegn
Copy link
Contributor

I still think we need to specify how the application scope is referenced, just as a Traits reference is described from Line 121

@mikkelhegn
Copy link
Contributor

Oh wait - I see :-)

The Scope is defined above the component. However that is meant to be the definition of the Application Scope instance, not the reference. That definition of the instance should move #144
Then it will make sense to have the appscope reference from the component defined as the trait reference is.

@hongchaodeng
Copy link
Member Author

hongchaodeng commented Sep 17, 2019

This depends on https://github.com/microsoft/hydra-spec/pull/147

@hongchaodeng
Copy link
Member Author

Let me close this and create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants