-
Notifications
You must be signed in to change notification settings - Fork 250
6.configuration.md: fix scope in example #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM |
mikkelhegn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should resolve the two new issue I raised before merging this (at least we get things sorted out as we move along :-))
Will see if I can submit these today...
6.operational_configuration.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest the example property be something different, to show it's configuring the application scope (all depending on the applicationScope capabilities)
I know this https://github.com/microsoft/hydra-spec/blob/master/4.application_scopes.md#network-scope is mentioning a networkName, but that's a bit weird as we now have a name as part of the spec and a parameter, so we should og back and get the core network scope fixed as well (will raise an issue)
properties:
- name: ingressVisibility
value: true
- name: subnetName
value: "[fromVariable(subnet-name)]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be fixed by #140
6.operational_configuration.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's yet to be defined how this should look: https://github.com/microsoft/hydra-spec/blob/master/6.operational_configuration.md#component - I've seen both just a name reference, but also a type. I suggest we assume this will be similar to Traits: https://github.com/microsoft/hydra-spec/blob/master/6.operational_configuration.md#trait
applicationScopes:
- name: testNetworkScope2
type: core.hydra.io/v1alpha1.Network
issue: https://github.com/microsoft/hydra-spec/issues/130 to specifically track this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a name with a type is OK, though it's even impossible for two app scopes to use same name in real user cases
|
I still think we need to specify how the application scope is referenced, just as a Traits reference is described from Line 121 |
|
Oh wait - I see :-) The Scope is defined above the component. However that is meant to be the definition of the Application Scope instance, not the reference. That definition of the instance should move #144 |
|
This depends on https://github.com/microsoft/hydra-spec/pull/147 |
|
Let me close this and create a new one. |
part of https://github.com/microsoft/hydra-spec/issues/119