add caching target#98
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new persistence/caching selector to the public gRPC/protobuf API so callers can target permanent storage vs cached storage, and updates the Go SDK’s generated protobuf bindings accordingly.
Changes:
- Introduces
PersistanceTargetenum intended to distinguish PERMANENT vs CACHED behavior. - Adds optional
targetfields toObject,QueryRequest, andGetRequest. - Updates generated Go protobuf code (
api.pb.go) to include the new enum and fields.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| proto/v1/api.proto | Adds the new enum and target fields to request/object messages. |
| sdk/go/v1/api.pb.go | Regenerates/updates Go protobuf bindings to reflect the new enum and fields. |
Files not reviewed (1)
- sdk/go/v1/api.pb.go: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot stopped work on behalf of
raphael-goetz due to an error
May 22, 2026 15:41
raphael-goetz
commented
May 22, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
raphael-goetz
commented
May 22, 2026
Co-authored-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
maximjsx
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #97