Skip to content

fix: avoid NPE if zip stream is empty in RetrieveExport endpoint #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyg merged 1 commit into from
Nov 29, 2025
Merged

fix: avoid NPE if zip stream is empty in RetrieveExport endpoint #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions library/src/main/java/dev/andstuff/kraken/api/endpoint/account/ReportDataEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ public ReportDataEndpoint(ReportDataParams params) {
@Override
public List<LedgerEntry> processZipResponse(ZipInputStream zipStream) throws IOException {
ZipEntry zipEntry = zipStream.getNextEntry();
if (zipEntry == null) {
log.error("No entries found in zip stream, report will be empty");
return List.of();
}

log.info("Processing zip entry: {}", zipEntry.getName());
InputStreamReader streamReader = new InputStreamReader(zipStream);
Expand Down