feat(move,swap): wrapping around sibling lists#885
Open
mazunki wants to merge 1 commit intonvim-treesitter:mainfrom
Open
feat(move,swap): wrapping around sibling lists#885mazunki wants to merge 1 commit intonvim-treesitter:mainfrom
mazunki wants to merge 1 commit intonvim-treesitter:mainfrom
Conversation
this adds support for wrapping around on parameter lists by querying the surrounding scope
Author
|
rebased to address linter issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was a bit surprised that
@parameter.innerwould go to the next procedure call, and not stop at the end of the parameter list when swapping order.I've added support for
opts = { wrap = true }which limits the scope in whichmove.goto_{next,previous}{,_end,_start}andswap.swap_{next,previous}operate.By default, this feature is disabled, and the API remains unchanged: so the feature is entirely opt-in. My opinion is that at the very least, the swapping commands should wrap around its siblings, but I don't intend on breaking expectations with this PR.
I haven't tested this on other things than parameter lists, but I suspect it would work with them just the same.