feat: add bitbucket icon#639
Conversation
| ["vite.config.js"] = { icon = "", color = "#FFA800", cterm_color = "214", name = "ViteConfig" }, | ||
| ["vite.config.mjs"] = { icon = "", color = "#FFA800", cterm_color = "214", name = "ViteConfig" }, | ||
| ["vite.config.mts"] = { icon = "", color = "#FFA800", cterm_color = "214", name = "ViteConfig" }, | ||
| ["vite.config.ts"] = { icon = "", color = "#FFA800", cterm_color = "214", name = "ViteConfig" }, |
There was a problem hiding this comment.
looks like these lines were padded by tabs, not spaces. Since I touch the whole file anyways, should I go ahead and reformat these with spaces? Or is it better to do in a separate PR?
There was a problem hiding this comment.
Good spot.
Yes, please do change to spaces and regenerate. They will also be ordered correctly after that.
| ["QtProject.conf"] = { icon = "", color = "#40CD52", cterm_color = "77", name = "Qt" }, | ||
| ["_gvimrc"] = { icon = "", color = "#019833", cterm_color = "28", name = "Gvimrc" }, | ||
| ["_vimrc"] = { icon = "", color = "#019833", cterm_color = "28", name = "Vimrc" }, | ||
| ["bitbucket-pipelines.yml"] = { icon = "", color = "#2684FF", cterm_color = "33", name = "BitbucketPipelinesConfig" }, |
There was a problem hiding this comment.
here's the new icon
There was a problem hiding this comment.
Dark and light icons look good.
|
@alex-courtis hey there, I'm new here and I'm not sure if I'm supposed to signal anything else on top of creating the PR. Got any feedback? I left couple questions, too. |
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Please:
- Fix formatting as discussed
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Many thanks for your contribution!
2 participants
This PR adds an icon for bitbucket-pipelines.yml file.
I found 3 size variations of NF Bitbucket icon, tested all of them and chose medium-sized nf-md-bitbucket, it fits the best with other devicons:
HEX color is taken from the official icon.
Is it okay that the entire file got changed by formatter? I see that all other lines have 1 extra space now - looks like the name I added is the longest so far.
The new icon is on line 76.