Skip to content

Using compresslevel=0 to have reasonable eff save time #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
borisfom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Using compresslevel=0 to have reasonable eff save time #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nemo2riva/cookbook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ def save_archive(model, save_path, cfg, artifacts, metadata):
logging.info("Saving to {}".format(save_path))
# Create EFF archive.
Archive.save_registry(
save_path=save_path, registry_name="artifacts", registry=artifacts, **metadata,
save_path=save_path, registry_name="artifacts", registry=artifacts,
tarfile_open_options={'compresslevel': 0, 'copybufsize': 64*1024*1024}, **metadata,
)
del artifacts
gc.collect()
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@

pyarmor<8
nemo_toolkit>=1.6.0
nvidia-eff>=0.5.3,<=0.6.2
nvidia-eff>=0.5.3
Copy link

@virajkarandikar virajkarandikar Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure >=0.5.3 is ok? I think tarfile options were available from 0.6.4 onwards.
See https://gitlab-master.nvidia.com/dl/riva/riva-speech/-/merge_requests/1034

Copy link
Collaborator Author

@borisfom borisfom Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, my new code did not break - but had no effect with 0.5.7.
Is it safe to enforce >=0.6.4 ?

onnxruntime-gpu>=1.13.1
onnx_graphsurgeon