-
Notifications
You must be signed in to change notification settings - Fork 1
chore!: update dotnet 10 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4972521 to
3a6229a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the BackButtonManager project from .NET 8 to .NET 10, including all dependencies, build tools, and language versions. This is a major breaking change as indicated in the metadata.
Key changes:
- Updates all target frameworks from
net8.0tonet10.0and mobile/Windows variants - Updates C# LangVersion from 12.0 to 14.0
- Updates all package dependencies to versions compatible with .NET 10, including Microsoft.Extensions, testing frameworks, and Uno.WinUI
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BackButtonManager/BackButtonManager.csproj | Updates LangVersion to 14.0 and dependency packages (Microsoft.Extensions.Logging.Abstractions, Microsoft.SourceLink.GitHub) |
| src/BackButtonManager.Uno.WinUI/BackButtonManager.Uno.WinUI.csproj | Updates target frameworks to net10.0, changes SDK from MSBuild.Sdk.Extras to Microsoft.NET.Sdk, updates Windows SDK target, and updates Uno.WinUI and other dependencies |
| src/BackButtonManager.Uno.WinUI/winappsdk-workaround.targets | Updates Windows SDK version reference in comment from 19041 to 20348 |
| src/BackButtonManager.Tests/BackButtonManager.Tests.csproj | Updates target framework to net10.0, LangVersion to 14.0, and all testing dependencies (coverlet, xunit, Moq, FluentAssertions, Microsoft.NET.Test.Sdk) |
| src/BackButtonManager.Abstractions/BackButtonManager.Abstractions.csproj | Updates LangVersion to 14.0 and dependency packages |
| build/stage-build.yml | Updates .NET SDK version to 10.0.100 and UnoCheck version and manifest |
| build/azure-pipelines.yml | Updates Windows hosted agent image from windows-2022 to windows-2025 |
| BREAKING_CHANGES.md | Documents the .NET 8 to 10 update as version 4.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/BackButtonManager.Uno.WinUI/BackButtonManager.Uno.WinUI.csproj
Outdated
Show resolved
Hide resolved
src/BackButtonManager.Uno.WinUI/BackButtonManager.Uno.WinUI.csproj
Outdated
Show resolved
Hide resolved
3a6229a to
82c372a
Compare
725b604 to
fd8aecb
Compare
|
I have an issue with the Mac OS workload; I think I will remove it. |
fd8aecb to
a3d93d8
Compare
a3d93d8 to
a7ae8b0
Compare
a7ae8b0 to
2a241af
Compare
GitHub Issue: #
Proposed Changes
What is the current behavior?
Targets .NET 8.
Targets Uno 5.
What is the new behavior?
Targets .NET 10.
Targets Uno 6.
Removed support for Mac OS.
Impact on version
buildfolder was changed..githubfolder was changed.Checklist
Please check that your PR fulfills the following requirements:
Documentation has been added/updated.Automated Unit / Integration tests for the changes have been added/updated.Other information