Preserve data when regenerating json files from addon-datastore#37
Preserve data when regenerating json files from addon-datastore#37nvdaes wants to merge 1 commit intonvaccess:mainfrom
Conversation
|
This approach doesn't look right. Other data is what is being deleted, not just translations. The commit generated from testing still looks broken: nvdaes/addon-datastore@2b688a1. Please confirm testing before marking as ready |
|
@seanbudd I think that the problem is not related to this repo. Imo we should handle reviewUrl, vtUrl and scanResult fields, not added to the regenerated json file. |
|
I don't think we should regenerate these fields, just preserve them. I believe the issue is related to the action to regenerate files. All we need to do in |
I think we should regenerate translations and changelog, but this is useful just if an action failed previously, since the add-on is inmutable and sha256 cannot be changed. So this may be useful if a new metadata is introduced. |
|
new metadata cant be introduced was the files shouldn't have changed. the sha is of the add-on file. we are just updating the JSON based off the same old add-on file. all regenerations function should do is regenerate the changelog and translations field on existing data, leaving the rest untouched |
|
@seanbudd, this should be fixed now in nvaccess/addon-datastore-validation#57. |
### Description
In PR nvaccess/addon-datastore#7368, a bug was introduced where security data was removed from json files
### Development approach
With assistance of Copilot, seems that when deleting translations the dictionary is mutated so that then some data is not added in the transformation.
So, instead of deleting translations directly, data is copied to a different dictionary and then added to json files as appropriate.
### Testing performed
Currently tests are been performed at
https://github.com/nvdaes/addon-datastore/actions/runs/21413861127
### Note
@seanbudd, if it's posible that I cannot way tonight until tests are finished. Please feel free to see results and proceed to merge if appropriate.