Skip to content

feat(EditorDragHandle): proxy nested / nestedOptions props and emit hover event #5960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjamincanac merged 12 commits into from
Jan 29, 2026
Merged

feat(EditorDragHandle): proxy nested / nestedOptions props and emit hover event #5960

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
343da96
fix(EditorDragHandle): update props forwarding to include 'nested' an…
solidprinciples Jan 27, 2026
1fc21a8
feat(editor): add custom middleware support to FloatingUIOptions
solidprinciples Jan 28, 2026
0a4d48f
docs(editor): Add typedocs custom middleware array
solidprinciples Jan 28, 2026
bb9ac64
fix(EditorDragHandle): align nodeChange to intended behavior, preserv…
solidprinciples Jan 28, 2026
478603b
fix(editor): rename emit to nodeChanged to resolve rendering issue
solidprinciples Jan 28, 2026
5b6e015
fix(editor): use updated emit
solidprinciples Jan 28, 2026
c619804
feat(EditorDragHandle): add @hover emit for when drag handles move no…
solidprinciples Jan 28, 2026
9446069
nit: revert unrelated changes
solidprinciples Jan 28, 2026
d23aa09
nit: revert unrelated changes
solidprinciples Jan 28, 2026
2597e4a
nit: revert/simplify
solidprinciples Jan 28, 2026
611c6f6
fix(EditorDragHandle): handle negative position values in onNodeChang…
solidprinciples Jan 29, 2026
09a4bb7
nit: revert
solidprinciples Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/runtime/components/EditorDragHandle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export interface EditorDragHandleSlots {

export interface EditorDragHandleEmits {
nodeChange: [{ node: JSONContent, pos: number }]
hover: [{ node: JSONContent, pos: number }]
Comment thread
solidprinciples marked this conversation as resolved.
}
Comment thread
solidprinciples marked this conversation as resolved.
</script>

Expand All @@ -65,8 +66,8 @@ const props = withDefaults(defineProps<EditorDragHandleProps>(), {
defineSlots<EditorDragHandleSlots>()
const emit = defineEmits<EditorDragHandleEmits>()

const dragHandleProps = useForwardProps(reactivePick(props, 'pluginKey', 'onElementDragEnd', 'onElementDragStart', 'getReferencedVirtualElement'))
const buttonProps = useForwardProps(reactiveOmit(props, 'icon', 'options', 'editor', 'pluginKey', 'onElementDragEnd', 'onElementDragStart', 'getReferencedVirtualElement', 'class', 'ui'))
const dragHandleProps = useForwardProps(reactivePick(props, 'pluginKey', 'nested', 'nestedOptions', 'onElementDragEnd', 'onElementDragStart', 'getReferencedVirtualElement'))
const buttonProps = useForwardProps(reactiveOmit(props, 'icon', 'options', 'editor', 'pluginKey', 'nested', 'nestedOptions', 'onElementDragEnd', 'onElementDragStart', 'getReferencedVirtualElement', 'class', 'ui'))

const appConfig = useAppConfig() as EditorDragHandle['AppConfig']

Expand Down Expand Up @@ -114,13 +115,19 @@ const currentNodePos = ref<number | null>()

function onNodeChange({ pos }: { pos: number }) {
currentNodePos.value = pos
if (pos == null || pos < 0) return

const node = props.editor.state.doc.nodeAt(pos)
if (node) {
emit('hover', { node: node.toJSON(), pos })
}
}

function onClick() {
if (!props.editor) return

const pos = currentNodePos.value
if (pos == null) return
if (pos == null || pos < 0) return

const node = props.editor.state.doc.nodeAt(pos)
if (node) {
Expand Down
Loading