Skip to content

fix(config): do not override vitest root with nuxt rootDir #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 1 commit into from
Jan 4, 2026
Merged

fix(config): do not override vitest root with nuxt rootDir #1531

danielroe merged 1 commit into from
Jan 4, 2026

Conversation

@yamachi4416
Copy link
Collaborator

@yamachi4416 yamachi4416 commented Jan 2, 2026 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this addresses the issue pointed out in this comment
nuxt/ui#5794 (comment)

and added some unit tests for the config.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 2, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/test-utils@1531

commit: fc5a24f

@yamachi4416 yamachi4416 changed the title fix(config): do not overwrite vitest root with nuxt rootDir fix(config): do not override vitest root with nuxt rootDir Jan 2, 2026
@yamachi4416 yamachi4416 force-pushed the fix/vitest-config-root branch from bdb0c5c to fc5a24f Compare January 2, 2026 07:28
@yamachi4416 yamachi4416 marked this pull request as ready for review January 2, 2026 07:40
@yamachi4416 yamachi4416 requested a review from danielroe as a code owner January 2, 2026 07:40
@danielroe danielroe merged commit 7966038 into nuxt:main Jan 4, 2026
7 checks passed
@github-actions github-actions bot mentioned this pull request Jan 4, 2026
Merged
@yamachi4416 yamachi4416 deleted the fix/vitest-config-root branch January 4, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yamachi4416 @danielroe