feat(types): add NOT IN to SQLOperator type#3785
Conversation
The query builder already handles NOT IN at runtime (case 'NOT IN' in the switch statement), but the TypeScript type does not expose it, forcing users to cast or suppress type errors when using it. Fixes nuxt#3766
|
Someone is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request adds Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Description
The query builder already handles
NOT INat runtime:However, the
SQLOperatortype does not include'NOT IN', so TypeScript users cannot use it without type assertions.Fix
Add
'NOT IN'to theSQLOperatortype union (placed next to'IN'for logical grouping).Changes
src/types/query.ts: Add'NOT IN'toSQLOperatorFixes #3766