fix(versions): catch missing nuxt in getNuxtVersion#1307
fix(versions): catch missing nuxt in getNuxtVersion#1307
Conversation
commit: |
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
=======================================
Coverage ? 54.53%
=======================================
Files ? 49
Lines ? 1212
Branches ? 338
=======================================
Hits ? 661
Misses ? 453
Partials ? 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| export async function getNuxtVersion(cwd: string, cache = true) { | ||
| const nuxtPkg = await readPackageJSON('nuxt', { url: cwd, try: true, cache }) | ||
| const nuxtPkg = await readPackageJSON('nuxt', { url: cwd, try: true, cache }).catch(() => null) |
There was a problem hiding this comment.
this seems like a bug, if so, because try: true should do this automatically
There was a problem hiding this comment.
Ah, understand. I'll have a look.
🔗 Linked issue
Fixes: #1179
📚 Description
npm create nuxt@latest -- test --template=minimal --modules=eslint --install=falseWith
--install=false, the template is downloaded butNuxtis never installed.getNuxtVersionthen can't find it and throws an error. The error wasn't caught. Now we simple caught it and the process can finish correctly.