Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
nuxt-better-auth-demo | 608d25f | Feb 05 2026, 07:01 PM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1f8115e8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type _ClientConfig = ReturnType<typeof getClientConfig> | ||
| declare module '#nuxt-better-auth' { | ||
| export type AppAuthClient = ReturnType<typeof createAppAuthClient> | ||
| export type AppAuthClient = ReturnType<(typeof createAuthClient)<_ClientConfig>> |
There was a problem hiding this comment.
The generated declaration string uses ReturnType<(typeof createAuthClient)<_ClientConfig>>, which is not a valid way to instantiate a generic function type in TypeScript, so consumers can hit a parse/type error in the emitted nuxt-better-auth-client.d.ts during nuxi prepare/typecheck. This breaks module typings for all projects that consume the generated declaration; the type needs to be expressed with a valid instantiation form.
Useful? React with 👍 / 👎.
| import { computed, nextTick, useRequestHeaders, useRequestURL, useRuntimeConfig, useState, watch } from '#imports' | ||
| import { createAuthClient } from 'better-auth/vue' | ||
|
|
||
| type AuthClient = ReturnType<typeof createAuthClient> |
There was a problem hiding this comment.
useUserSession now aliases AuthClient to ReturnType<typeof createAuthClient> instead of the generated AppAuthClient, which drops plugin-aware typing from the user/module client config. In projects that add client plugins (including via the new better-auth:client:extend hook), runtime methods exist but client, signIn, and signUp are no longer typed with those extensions, forcing unsafe casts and undermining the new extension flow.
Useful? React with 👍 / 👎.
onmax
changed the title
|
Closing: the docs fix was merged via #94 and this PR also includes unrelated feature work with failing CI. We'll re-open the client-extend work as a clean PR off main. |
1 participant
Summary
better-authas required for adapter imports@better-auth/cliauth.tsexample and--configusageTests
Closes #93