Skip to content

DO NOT MERGE: Project branch for Generic Functions#3983

Draft
reinkrul wants to merge 61 commits intomasterfrom
project-gf
Draft

DO NOT MERGE: Project branch for Generic Functions#3983
reinkrul wants to merge 61 commits intomasterfrom
project-gf

Conversation

@reinkrul
Copy link
Member

@reinkrul reinkrul commented Feb 2, 2026

This is a merger of the following 2 feature branches:

  • lspxnuts
  • iss3980-validate-idtoken-credential (DeziIDTokenCredential support)
  • copilot/improve-client-error-message (to return "credential is revoked" error message to the client)

It also:

  • For demo-ing revocation: lists revoked/expired credentials in wallet.List() and always update statuslist credentials (bypass cache)

The features in these branches will be merged into the master branch individually (or not).

@qltysh
Copy link

qltysh bot commented Feb 2, 2026

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on master by 0.56%.

Modified Files with Diff Coverage (18)

RatingFile% DiffUncovered Line #s
Coverage rating: C Coverage rating: C
auth/auth.go100.0%
Coverage rating: B Coverage rating: B
vcr/cmd/cmd.go0.0%44-45
Coverage rating: A Coverage rating: B
core/tls.go0.0%76-80
Coverage rating: A Coverage rating: A
cmd/root.go100.0%
Coverage rating: B Coverage rating: B
auth/api/iam/api.go83.3%761-762, 798-799
Coverage rating: B Coverage rating: B
auth/client/iam/openid4vp.go84.2%70-83, 261-262, 275-276
Coverage rating: B Coverage rating: C
auth/client/iam/client.go58.5%238-239, 242-243...
Coverage rating: C Coverage rating: C
vcr/vcr.go100.0%
Coverage rating: B Coverage rating: B
vcr/holder/sql_wallet.go100.0%
Coverage rating: A Coverage rating: B
vcr/credential/util.go0.0%122-132
Coverage rating: A Coverage rating: A
vcr/revocation/types.go100.0%
Coverage rating: B Coverage rating: B
vcr/holder/presenter.go77.1%118-119, 125-126...
Coverage rating: A Coverage rating: A
vdr/didx509/resolver.go100.0%
Coverage rating: A Coverage rating: A
vcr/verifier/verifier.go33.3%157-158
Coverage rating: A Coverage rating: B
vcr/credential/resolver.go0.0%47-51
Coverage rating: B Coverage rating: B
vcr/pe/presentation_submission.go100.0%
Coverage rating: A Coverage rating: B
vcr/revocation/statuslist2021_verifier.go100.0%
New file Coverage rating: F
vcr/credential/dezi.go44.1%24-26, 75-76, 80-81...
Total54.5%
🤖 Increase coverage with AI coding...

In the `project-gf` branch, add test coverage for this new code:

- `auth/api/iam/api.go` -- Lines 761-762 and 798-799
- `auth/client/iam/client.go` -- Lines 238-239, 242-243, and 253-265
- `auth/client/iam/openid4vp.go` -- Lines 70-83, 261-262, and 275-276
- `core/tls.go` -- Line 76-80
- `vcr/cmd/cmd.go` -- Line 44-45
- `vcr/credential/dezi.go` -- Lines 24-26, 75-76, 80-81, 86-87, 90-91, 122-248, 262-263, 303-304, 306-307, 311-312, 329-330, 332-333, 339-340, 343-344, 358, 367-370, 379-380, 387-388, 391-392, 396-397, 400-401, 404-405, and 428-489
- `vcr/credential/resolver.go` -- Line 47-51
- `vcr/credential/util.go` -- Line 122-132
- `vcr/holder/presenter.go` -- Lines 118-119, 125-126, 133-134, and 138-139
- `vcr/verifier/verifier.go` -- Line 157-158

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants