Dev #3

gamesguru · 2024-03-02T17:47:29Z

No description provided.

gamesguru · 2024-04-23T01:44:29Z

still need to revisit the variable name changes and such in process.py

gamesguru · 2026-01-12T10:09:22Z

@cubic-dev-ai review this pull request

cubic-dev-ai · 2026-01-12T10:09:28Z

@cubic-dev-ai review this pull request

@gamesguru I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai · 2026-01-12T10:09:31Z

@cubic-dev-ai review this pull request

@gamesguru I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

4 issues found across 9 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="Makefile">

<violation number="1" location="Makefile:75">
P1: Interactive confirmation prompt won't work because `$(shell ...)` is evaluated during Make's parse phase, not during recipe execution. The `read` command requires an interactive terminal that isn't available at parse time, so this safety check will fail or be bypassed. This is dangerous for a destructive operation that deletes releases and tags.</violation>
</file>

<file name=".github/workflows/test.yml">

<violation number="1" location=".github/workflows/test.yml:14">
P1: Self-hosted runner with write permissions and broad branch triggers creates security risk. Consider: (1) restricting the trigger to specific branches like `main`/`master` only, (2) using GitHub-hosted runners for untrusted branches, or (3) removing write permissions and using a separate workflow for deployments.</violation>

<violation number="2" location=".github/workflows/test.yml:46">
P2: Quote the $RELEASE_TAG variable to prevent word splitting and handle empty/special values safely.</violation>
</file>

<file name="sql/latest_version.py">

<violation number="1" location="sql/latest_version.py:27">
P2: When version.csv contains only the header row, this code prints the literal string "version" instead of indicating that no version is available. Guard against the header-only case before printing.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-01-12T10:17:37Z

Makefile

+
+.PHONY: deploy/delete
+deploy/delete:
+	[[ "$(shell read -e -p 'Really delete v${DB_VERSION}? [y/N]> '; echo $$REPLY)" == [Yy]* ]]


P1: Interactive confirmation prompt won't work because $(shell ...) is evaluated during Make's parse phase, not during recipe execution. The read command requires an interactive terminal that isn't available at parse time, so this safety check will fail or be bypassed. This is dangerous for a destructive operation that deletes releases and tags.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At Makefile, line 75: <comment>Interactive confirmation prompt won't work because `$(shell ...)` is evaluated during Make's parse phase, not during recipe execution. The `read` command requires an interactive terminal that isn't available at parse time, so this safety check will fail or be bypassed. This is dangerous for a destructive operation that deletes releases and tags.</comment> <file context> @@ -0,0 +1,97 @@ + +.PHONY: deploy/delete +deploy/delete: + [[ "$(shell read -e -p 'Really delete v${DB_VERSION}? [y/N]> '; echo $$REPLY)" == [Yy]* ]] + gh release delete v${DB_VERSION} + git push origin --delete v${DB_VERSION} </file context>

cubic-dev-ai · 2026-01-12T10:17:37Z

.github/workflows/test.yml

+
+jobs:
+  ci:
+    runs-on: [self-hosted, dev]


P1: Self-hosted runner with write permissions and broad branch triggers creates security risk. Consider: (1) restricting the trigger to specific branches like main/master only, (2) using GitHub-hosted runners for untrusted branches, or (3) removing write permissions and using a separate workflow for deployments.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/test.yml, line 14: <comment>Self-hosted runner with write permissions and broad branch triggers creates security risk. Consider: (1) restricting the trigger to specific branches like `main`/`master` only, (2) using GitHub-hosted runners for untrusted branches, or (3) removing write permissions and using a separate workflow for deployments.</comment> <file context> @@ -0,0 +1,59 @@ + +jobs: + ci: + runs-on: [self-hosted, dev] + steps: + - name: Checkout </file context>

cubic-dev-ai · 2026-01-12T10:17:38Z

.github/workflows/test.yml

+          gh release list -L 1
+          # TODO: enhance this to be: if release_tag > current_prod_tag, deploy.
+          #       Otherwise, can skip this step entirely?
+          gh release view $RELEASE_TAG || echo "PUBLISH=1" >> "$GITHUB_OUTPUT"


P2: Quote the $RELEASE_TAG variable to prevent word splitting and handle empty/special values safely.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/test.yml, line 46: <comment>Quote the $RELEASE_TAG variable to prevent word splitting and handle empty/special values safely.</comment> <file context> @@ -0,0 +1,59 @@ + gh release list -L 1 + # TODO: enhance this to be: if release_tag > current_prod_tag, deploy. + # Otherwise, can skip this step entirely? + gh release view $RELEASE_TAG || echo "PUBLISH=1" >> "$GITHUB_OUTPUT" + + # yamllint disable rule:line-length </file context>

Suggested change

gh release view $RELEASE_TAG || echo "PUBLISH=1" >> "$GITHUB_OUTPUT"

gh release view "$RELEASE_TAG" || echo "PUBLISH=1" >> "$GITHUB_OUTPUT"

cubic-dev-ai · 2026-01-12T10:17:39Z

sql/latest_version.py

+            rows = list(reader)
+
+        # Print latest version
+        print(rows[-1][1])


P2: When version.csv contains only the header row, this code prints the literal string "version" instead of indicating that no version is available. Guard against the header-only case before printing.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At sql/latest_version.py, line 27: <comment>When version.csv contains only the header row, this code prints the literal string "version" instead of indicating that no version is available. Guard against the header-only case before printing.</comment> <file context> @@ -0,0 +1,36 @@ + rows = list(reader) + + # Print latest version + print(rows[-1][1]) + return 0 + </file context>

cubic-dev-ai

2 issues found across 9 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/test.yml">

<violation number="1" location=".github/workflows/test.yml:46">
P1: The release existence check is fragile. `gh release view` failing doesn't always mean the release doesn't exist—it could be a network error, auth failure, or rate limit. Consider checking the specific exit code or error message to distinguish between "release not found" and other failures.</violation>
</file>

<file name="README.rst">

<violation number="1" location="README.rst:1">
P2: The overline/underline around the document title use 13 asterisks while the title text is 12 characters, violating reStructuredText’s requirement that section adornments match the title length and causing Docutils warnings.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-01-12T10:29:02Z

.github/workflows/test.yml

+          gh release list -L 1
+          # TODO: enhance this to be: if release_tag > current_prod_tag, deploy.
+          #       Otherwise, can skip this step entirely?
+          gh release view $RELEASE_TAG || echo "PUBLISH=1" >> "$GITHUB_OUTPUT"


P1: The release existence check is fragile. gh release view failing doesn't always mean the release doesn't exist—it could be a network error, auth failure, or rate limit. Consider checking the specific exit code or error message to distinguish between "release not found" and other failures.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/test.yml, line 46: <comment>The release existence check is fragile. `gh release view` failing doesn't always mean the release doesn't exist—it could be a network error, auth failure, or rate limit. Consider checking the specific exit code or error message to distinguish between "release not found" and other failures.</comment> <file context> @@ -0,0 +1,59 @@ + gh release list -L 1 + # TODO: enhance this to be: if release_tag > current_prod_tag, deploy. + # Otherwise, can skip this step entirely? + gh release view $RELEASE_TAG || echo "PUBLISH=1" >> "$GITHUB_OUTPUT" + + # yamllint disable rule:line-length </file context>

cubic-dev-ai · 2026-01-12T10:29:02Z

README.rst

+*************
 usda-sqlite
-***********
+*************


P2: The overline/underline around the document title use 13 asterisks while the title text is 12 characters, violating reStructuredText’s requirement that section adornments match the title length and causing Docutils warnings.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At README.rst, line 1: <comment>The overline/underline around the document title use 13 asterisks while the title text is 12 characters, violating reStructuredText’s requirement that section adornments match the title length and causing Docutils warnings.</comment> <file context> @@ -1,9 +1,9 @@ -*********** +************* usda-sqlite -*********** </file context>

Suggested change

*************

usda-sqlite

***********

*************

***********

usda-sqlite

***********

gamesguru added 4 commits March 2, 2024 11:24

wip makefile, github workflow

c936d61

wip format

10b209e

fixup makefile more

fa3c02f

try fixing workflow yaml too

3aca76b

gamesguru force-pushed the dev branch from d096817 to 3aca76b Compare March 2, 2024 17:50

gamesguru added 9 commits March 2, 2024 14:23

try-except in latest_version.py

33d939c

black .

72a4b75

unset intentional error

12b0ee9

TEST THIS: updated process.py

92d59c3

fix process.py

cb96f66

add check-vars

abe0f4d

update makefile, workflow

9244f27

lint sql/latest_version.py

91a4183

fix README title and status badge (image)

810083f

gamesguru force-pushed the dev branch from 20063dd to 810083f Compare April 18, 2024 15:48

gamesguru added 8 commits April 18, 2024 12:06

makefile, readme

c949dc0

del deploy/install-prod and _check-git-up-to-date

905b3a2

update readme

ef9a059

add make docs target

a96acca

adjust sections in Makefile

d8a4732

remove old travis CI config file

bf29771

remove TODO

8f27bfe

remove format.sh; remove blank line in py file

8324bf3

cubic-dev-ai bot reviewed Jan 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev #3

Dev #3

Uh oh!

gamesguru commented Mar 2, 2024

Uh oh!

gamesguru commented Apr 23, 2024

Uh oh!

gamesguru commented Jan 12, 2026

Uh oh!

cubic-dev-ai bot commented Jan 12, 2026

Uh oh!

cubic-dev-ai bot commented Jan 12, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

	gh release view $RELEASE_TAG \|\| echo "PUBLISH=1" >> "$GITHUB_OUTPUT"
	gh release view "$RELEASE_TAG" \|\| echo "PUBLISH=1" >> "$GITHUB_OUTPUT"

Dev #3

Are you sure you want to change the base?

Dev #3

Uh oh!

Conversation

gamesguru commented Mar 2, 2024

Uh oh!

gamesguru commented Apr 23, 2024

Uh oh!

gamesguru commented Jan 12, 2026

Uh oh!

cubic-dev-ai bot commented Jan 12, 2026

Uh oh!

cubic-dev-ai bot commented Jan 12, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading