dev 02 #2

gamesguru · 2026-01-21T10:59:57Z

Summary by cubic

Adds a database picker with recent files and a context menu to add foods to a meal from search results. Adds RDA and Profile settings, a Daily Log with macro progress bars, a Preferences dialog with usage stats and database sizes, and a recipe builder to create and manage recipes.

New Features
- Database picker: File menu with Open and Recent (last 5), plus startup browse prompt if not found; status bar shows DB connection state.
- About dialog shows version (from git tag).
- Search results context menu with Analyze and Add to Meal (weight dialog supports grams/oz/lb and serving sizes; adds to Meal Builder; can add to Daily Log).
- Daily Log tab shows today’s entries with calories and macro progress bars.
- Preferences dialog with Profile and RDA settings (overrides saved in user DB; %RDA now calculated), plus usage stats and database sizes.
Refactors
- CMake: auto-detect version from git or NUTRA_VERSION, define NUTRA_VERSION_STRING, use GNUInstallDirs, and generate nutra.desktop from a template with the correct Exec path.
- Makefile: pass detected version to CMake.
- CI: add a manual version bump workflow (patch/minor/major) that tags releases, and a release build workflow that builds artifacts on tag pushes.

^{Written for commit 3f165c8. Summary will update on new commits.}

cubic-dev-ai

No issues found across 7 files

cubic-dev-ai

No issues found across 9 files

cubic-dev-ai

1 issue found across 12 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/db/foodrepository.cpp">

<violation number="1" location="src/db/foodrepository.cpp:152">
P2: This function accesses `m_rdas` without first calling `ensureCacheLoaded()`. If `getFoodNutrients()` is called before the cache is loaded, `m_rdas` will be empty and all RDA percentages will incorrectly be 0.0. Consider adding `ensureCacheLoaded()` at the start of this function, similar to how `searchFoods()` does.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/db/foodrepository.cpp

cubic-dev-ai

5 issues found across 31 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/db/mealrepository.cpp">

<violation number="1" location="src/db/mealrepository.cpp:151">
P2: Missing error handling for `query.exec()`. Unlike `addFoodLog()` and `clearDailyLogs()` which log errors on failure, this will fail silently if the delete operation fails, leaving users unaware that the entry wasn't removed.</violation>
</file>

<file name="src/db/foodrepository.cpp">

<violation number="1" location="src/db/foodrepository.cpp:251">
P2: The return value of `query.prepare()` is not checked before calling `bindValue()` and `exec()`. If prepare fails (e.g., table doesn't exist), the error won't be properly handled. This is inconsistent with other functions in this file that check the prepare result.</violation>
</file>

<file name="src/db/databasemanager.cpp">

<violation number="1" location="src/db/databasemanager.cpp:20">
P2: Resource leak: `m_userDb` is opened in `initUserDatabase()` but never closed in the destructor. Add cleanup for the user database connection.</violation>

<violation number="2" location="src/db/databasemanager.cpp:76">
P1: Missing directory creation: The `~/.nutra/` directory may not exist on first run. SQLite cannot create parent directories, causing `m_userDb.open()` to fail. Use `QDir().mkpath()` to ensure the directory exists.</violation>
</file>

<file name="CMakeLists.txt">

<violation number="1" location="CMakeLists.txt:16">
P2: `file(GLOB_RECURSE ...)` won’t trigger reconfiguration when new files are added unless `CONFIGURE_DEPENDS` is specified, so new sources can be silently omitted from builds. Add `CONFIGURE_DEPENDS` or list sources explicitly.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/db/databasemanager.cpp

src/db/mealrepository.cpp

src/db/foodrepository.cpp

src/db/databasemanager.cpp

CMakeLists.txt

cubic-dev-ai

4 issues found across 11 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/version-bump.yml">

<violation number="1" location=".github/workflows/version-bump.yml:99">
P1: `${{ env.NEW_TAG }}` will be empty because environment variables set via `$GITHUB_ENV` are only available in subsequent steps, not the current step. Use the shell variable `$NEW_TAG` directly instead.</violation>
</file>

<file name="src/widgets/searchwidget.cpp">

<violation number="1" location="src/widgets/searchwidget.cpp:102">
P2: The description column is no longer populated, so descItem is null and double-click/context menu actions will no-op. Add the description item back when populating the row.</violation>
</file>

<file name="src/db/mealrepository.cpp">

<violation number="1" location="src/db/mealrepository.cpp:151">
P2: The query has one placeholder, but the new line binds a second parameter. This can break execution with a parameter count mismatch. Remove the extra bind.</violation>
</file>

<file name="src/widgets/dailylogwidget.cpp">

<violation number="1" location="src/widgets/dailylogwidget.cpp:153">
P2: Progress bar color is never reset after exceeding 100%. Once any bar turns purple (when pct > 100), it remains purple even when the percentage later drops below 100%, because the else branch is commented out. The bars should be reset to their original colors when below 100%.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

.github/workflows/version-bump.yml

src/widgets/searchwidget.cpp

src/db/mealrepository.cpp

src/widgets/dailylogwidget.cpp

cubic-dev-ai

4 issues found across 13 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/db/mealrepository.cpp">

<violation number="1" location="src/db/mealrepository.cpp:151">
P2: Binding the same parameter twice for a single placeholder supplies too many bound values, which can make the DELETE fail or behave unexpectedly. Only bind the value once.</violation>
</file>

<file name="src/widgets/dailylogwidget.cpp">

<violation number="1" location="src/widgets/dailylogwidget.cpp:155">
P2: Progress bar color is never reset after exceeding 100%. When `pct` drops back below 100%, the bar remains purple because the style reset is commented out. Consider storing original colors and setting the appropriate color on each update.</violation>
</file>

<file name=".github/workflows/release.yml">

<violation number="1" location=".github/workflows/release.yml:170">
P1: Release step points to artifact paths that don’t include the download directory. The files are downloaded under `artifacts/<name>/...`, so the current paths will fail to resolve and the release will not attach the artifacts.</violation>
</file>

<file name="src/widgets/searchwidget.cpp">

<violation number="1" location="src/widgets/searchwidget.cpp:102">
P2: The Description column is no longer populated; the new block never sets column 1, so search results will show empty descriptions.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

.github/workflows/release.yml

src/db/mealrepository.cpp

src/widgets/dailylogwidget.cpp

src/widgets/searchwidget.cpp

cubic-dev-ai

5 issues found across 13 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/widgets/dailylogwidget.cpp">

<violation number="1" location="src/widgets/dailylogwidget.cpp:153">
P2: Progress bar color is never reset after exceeding 100%. Once `pct > 100` turns the bar purple, it stays purple even when the value drops back below 100% because the reset logic is commented out. The original color should be restored in the else branch.</violation>
</file>

<file name="src/db/mealrepository.cpp">

<violation number="1" location="src/db/mealrepository.cpp:151">
P2: The query only has one placeholder, but you now bind two values. This can cause parameter count mismatch errors or ignore the intended value. Remove the extra bind.</violation>
</file>

<file name=".github/workflows/version-bump.yml">

<violation number="1" location=".github/workflows/version-bump.yml:99">
P0: Environment variable `env.NEW_TAG` is not available in the same step where it's set. Variables written to `$GITHUB_ENV` are only available in subsequent steps. Use the shell variable `$NEW_TAG` directly instead.</violation>
</file>

<file name=".github/workflows/release.yml">

<violation number="1" location=".github/workflows/release.yml:169">
P2: Release assets are referenced without the `artifacts/` prefix even though `download-artifact` extracts under that directory. The release step will not find the files.</violation>
</file>

<file name="src/widgets/searchwidget.cpp">

<violation number="1" location="src/widgets/searchwidget.cpp:102">
P2: The Description column is no longer populated because the new logic omits setting column 1. This leaves the Description column blank in the results table.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

.github/workflows/version-bump.yml

src/widgets/dailylogwidget.cpp

src/db/mealrepository.cpp

.github/workflows/release.yml

src/widgets/searchwidget.cpp

cubic-dev-ai

6 issues found across 19 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/widgets/profilesettingswidget.cpp">

<violation number="1" location="src/widgets/profilesettingswidget.cpp:64">
P2: Activity label initial text "2 (Lightly Active)" doesn't match the slider's default value. QSlider defaults to its minimum (1) after `setRange(1, 5)`, so if no profile is loaded, the UI shows inconsistent state. Initialize the slider to 2 or set the label to "1 (Sedentary)".</violation>
</file>

<file name="src/db/databasemanager.cpp">

<violation number="1" location="src/db/databasemanager.cpp:149">
P2: Fallback schema path `/usr/share/nutra/sql/tables.sql` is not verified to exist before calling applySchema. If neither path exists, database initialization silently fails.</violation>

<violation number="2" location="src/db/databasemanager.cpp:179">
P2: Return values of PRAGMA exec calls are not checked. If these fail silently, the database version remains 0, causing schema re-initialization on every startup.</violation>
</file>

<file name="tests/test_databasemanager.cpp">

<violation number="1" location="tests/test_databasemanager.cpp:40">
P2: Remove the named connection after closing to avoid lingering QSqlDatabase connections and file lock issues during cleanup.</violation>
</file>

<file name="src/widgets/searchwidget.cpp">

<violation number="1" location="src/widgets/searchwidget.cpp:248">
P2: Duplicate search triggered when selecting from history completer. `setText()` triggers `textChanged` which starts the debounce timer, then `performSearch()` is called immediately. When the timer fires, the search executes again. Stop the timer after setting the text to prevent the duplicate.</violation>
</file>

<file name="src/main.cpp">

<violation number="1" location="src/main.cpp:21">
P2: The lock file is created in the shared temp directory, so one user can prevent other users from starting the app. Use a per-user location (e.g., `RuntimeLocation`) or include user-specific data in the lock file path.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/widgets/profilesettingswidget.cpp

src/db/databasemanager.cpp

tests/test_databasemanager.cpp

src/widgets/searchwidget.cpp

src/main.cpp

cubic-dev-ai

4 issues found across 16 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="tests/test_databasemanager.cpp">

<violation number="1" location="tests/test_databasemanager.cpp:34">
P2: Call removeDatabase only after the `QSqlDatabase` object is destroyed; otherwise Qt warns that the connection is still in use. Clear `db` before removing the connection.</violation>

<violation number="2" location="tests/test_databasemanager.cpp:51">
P2: Call removeDatabase only after the `QSqlDatabase` object is destroyed; otherwise the connection remains in use. Reset `db` before removing the connection.</violation>
</file>

<file name="src/db/reciperepository.cpp">

<violation number="1" location="src/db/reciperepository.cpp:40">
P2: Missing error logging on query failure, inconsistent with other methods in this repository that log SQL errors.</violation>
</file>

<file name="src/widgets/recipewidget.cpp">

<violation number="1" location="src/widgets/recipewidget.cpp:280">
P2: Potential null pointer dereference. `ingredientsTable->item(row, 0)` can return `nullptr`. Add a null check before accessing the item's text.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

tests/test_databasemanager.cpp

src/db/reciperepository.cpp

src/widgets/recipewidget.cpp

cubic-dev-ai

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="CMakeLists.txt">

<violation number="1" location="CMakeLists.txt:92">
P2: The `appimage` target doesn’t depend on `nutra`, so invoking it can run before the executable is built. `cmake --install` won’t build targets, which can make AppImage generation fail. Add a dependency on `nutra` so the binary is built first.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

CMakeLists.txt

gamesguru added 2 commits January 21, 2026 05:49

wip

ad2de45

add some UI components to mainwindow

68da432

cubic-dev-ai bot reviewed Jan 21, 2026

View reviewed changes

wip

0a53c7a

cubic-dev-ai bot reviewed Jan 21, 2026

View reviewed changes

user db and some ui improvements

28debcc

cubic-dev-ai bot reviewed Jan 21, 2026

View reviewed changes

src/db/foodrepository.cpp Outdated Show resolved Hide resolved

gamesguru added 6 commits January 21, 2026 13:56

add recipes; format

4d6ff6d

lint & some database open logic

6208fd9

don't allow re-opening same DB (weird loop)

cb8142a

only run actions on pull request once (no double run push)

dffbe73

add status bar

ff7fc26

lint/fix cache not loaded potential condition

9359557

cubic-dev-ai bot reviewed Jan 21, 2026

View reviewed changes

src/db/databasemanager.cpp Outdated Show resolved Hide resolved

src/db/mealrepository.cpp Outdated Show resolved Hide resolved

src/db/foodrepository.cpp Outdated Show resolved Hide resolved

src/db/databasemanager.cpp Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

gamesguru added 6 commits January 21, 2026 14:27

add daily log (wip), and fix ubuntu 20.04 build

90af78e

cubic: handle database init/open logic

aaa481c

lint/tidy

a0a6b20

add info dialo

9b4288b

keep working on ui

98e0feb

version/release workflows. ui updates

95540d8

cubic-dev-ai bot reviewed Jan 21, 2026

View reviewed changes

.github/workflows/version-bump.yml Outdated Show resolved Hide resolved

src/widgets/searchwidget.cpp Show resolved Hide resolved

src/db/mealrepository.cpp Outdated Show resolved Hide resolved

src/widgets/dailylogwidget.cpp Show resolved Hide resolved

init preferences ui

ec99ee7

cubic-dev-ai bot reviewed Jan 21, 2026

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

src/db/mealrepository.cpp Outdated Show resolved Hide resolved

src/widgets/dailylogwidget.cpp Show resolved Hide resolved

src/widgets/searchwidget.cpp Show resolved Hide resolved

gamesguru added 2 commits January 21, 2026 16:20

lint & ui tweaks/stuff

9c7d0ef

combine rda into preferences dialog

6c3f4b5

cubic-dev-ai bot reviewed Jan 21, 2026

View reviewed changes

gamesguru added 4 commits January 21, 2026 16:45

update gitmodules: add ntsqlite, both mv -> lib

c070ca9

update db stuff

aeef1c6

better history

46ff83b

small lint; version bump & release tweak/fix

1f7e6eb

gamesguru added 3 commits January 21, 2026 21:26

database & ui stuff

1c460de

keep chugging

98de943

add some tests

2f934d1

cubic-dev-ai bot reviewed Jan 22, 2026

View reviewed changes

gamesguru added 2 commits January 22, 2026 00:54

qt 5.12 compat

15552da

update

338a2c5

cubic-dev-ai bot reviewed Jan 22, 2026

View reviewed changes

tests/test_databasemanager.cpp Show resolved Hide resolved

tests/test_databasemanager.cpp Show resolved Hide resolved

src/db/reciperepository.cpp Outdated Show resolved Hide resolved

src/widgets/recipewidget.cpp Outdated Show resolved Hide resolved

appimage target

e9fdb23

cubic-dev-ai bot reviewed Jan 24, 2026

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

lint fixes

3f165c8

dev 02 #2

Are you sure you want to change the base?

dev 02 #2

Uh oh!

Conversation

gamesguru commented Jan 21, 2026 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gamesguru commented Jan 21, 2026 •

edited by cubic-dev-ai bot

Loading