-
Notifications
You must be signed in to change notification settings - Fork 346
Fix export service error with the new timetable config schema #4277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix export service error with the new timetable config schema #4277
Conversation
Updated the validation logic in the export service
|
@zehata is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4277 +/- ##
==========================================
+ Coverage 54.52% 56.78% +2.26%
==========================================
Files 274 297 +23
Lines 6076 6924 +848
Branches 1455 1671 +216
==========================================
+ Hits 3313 3932 +619
- Misses 2763 2992 +229 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Yeah the export service is quite old and the testing issue was raised in #3926. We should probably do something about it. |
leslieyip02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
For future reference, we missed 3 issues:
Fixed by these commits: (this is pretty sloppy but I just wanted to get it fixed) |
Updated the validation logic in the export service
Context
Resolves https://t.me/NUSMods/13264
This was caused by the validation logic in
nusmods/export/src/data.ts
Lines 64 to 71 in f722758
The systemic problem is that there is currently no test coverage for the export service. It also took a long time to fix because the readme is really outdated.
Other Information
Sample image and pdf output of the export service, showing no regression from before #4225:

My Timetable.pdf