FIXED: Allow people to select another PREFIX path#1136
Open
TeaObvious wants to merge 1 commit intonullptrlabs:developfrom
Open
FIXED: Allow people to select another PREFIX path#1136TeaObvious wants to merge 1 commit intonullptrlabs:developfrom
TeaObvious wants to merge 1 commit intonullptrlabs:developfrom
Conversation
-> the actual issue is that towards the end of the install script where $INSTALL_ROOT is used instead of $PREFIX -> simplest fix was to set $INSTALL_ROOT to $PREFIX -> reordering some allows to use the DEPLOY_VER in the PREFIX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the actual issue is towards the end of the install script where $INSTALL_ROOT is used instead of $PREFIX
simplest fix was to set $INSTALL_ROOT to $PREFIX
reordering some lines allows to use the DEPLOY_VER in the PREFIX