Skip to content

refactor: Rewrite and cleanup #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ananos merged 7 commits into from
May 9, 2025
Merged

refactor: Rewrite and cleanup #16

ananos merged 7 commits into from
May 9, 2025

Conversation

@papazof
Copy link
Contributor

@papazof papazof commented Apr 28, 2025 •
edited
Loading

Rewrite package modules and extend API, cleanup, rewrite CI and modernize build process:

  • Auto-generate bindings and improve build process
  • Add CType abstract class to provide a common interface for C types, provide wrappers for built-in types and refactor vaccel components
  • Rewrite vaccel operations as Session mixins and move to ops
  • Add API support for TFLite and Torch operations
  • Update/extend tests and provide common pytest setup for environment variables and vaccel paths through pkg-config
  • Add a classify example and a script to run the examples
  • Improve and extend docstrings
  • Cleanup redundant files and code and add licensing information
  • Rewrite workflows based on the vaccel repo actions and move docs generation to nubificus/vaccel-docs

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@papazof papazof force-pushed the refactor_rewrite_and_cleanup branch 26 times, most recently from b83e40b to e1c9b5a Compare May 2, 2025 22:49
github-actions[bot]

This comment was marked as outdated.

Sign in to view

@papazof papazof force-pushed the refactor_rewrite_and_cleanup branch from e1c9b5a to f408ac8 Compare May 2, 2025 22:51
@papazof papazof force-pushed the refactor_rewrite_and_cleanup branch 4 times, most recently from be6a1d5 to 86adab5 Compare May 5, 2025 03:29
@papazof papazof force-pushed the refactor_rewrite_and_cleanup branch 4 times, most recently from 00a7e06 to 3c89cb9 Compare May 6, 2025 17:26
@papazof papazof marked this pull request as ready for review May 6, 2025 17:49
@papazof papazof requested a review from ananos May 6, 2025 17:49
ananos
ananos approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@ananos ananos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @papazof

papazof added 7 commits May 9, 2025 17:32
@papazof
refactor: Rewrite modules and improve build
54ea46c 
Rewrite package modules, cleanup and modernize build process:
- Move all configuration but `cffi`'s build trigger to `pyproject.toml`
- Rewrite build script for `cffi` to auto-generate bindings from the
  `vaccel.h` header
- Configure `setuptools` to build an `abi3` wheel (compatible with all
  Python versions >= 3.10)
- Add `CType` abstract class to provide a common interface for C types
- Implement wrappers based on `CType` for built-in Python types
- Refactor and improve `vaccel` components based on `CType`
- Rewrite `vaccel` operations as `Session` mixins
- Update/extend tests and provide common `pytest` setup for environment
  variables and vaccel paths through `pkg-config`
- Add a `classify` example with similar functionality to the C vaccel
  example
- Improve and extend docstrings
- Cleanup redundant files and code

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@papazof
feat: Add TFLite and Torch operations
b176f90 
Add API support for `TFLite` and `Torch` operations and relevant tests

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@papazof
refactor: Move operations to ops
2789837 
Move all operation mixins to the `ops` subpackage, mirroring the vaccel
C code structure

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@papazof
chore: Add license files and headers
1e14132 
Add `LICENSE`, `NOTICE` and license headers to files

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@papazof
ci: Rewrite workflows based on the vaccel repo
47595a3 
Rewrite workflows based on the vaccel repo actions and move docs
generation to `nubificus/vaccel-docs`

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@papazof
build: Add script to run examples
695cef3 
Add a `run-examples.py` script to run the examples with sample inputs
and configure the CI to use it

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@papazof
docs: Update README.md with latest instructions
33a3115 
Update `README.md` with latest instructions

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@github-actions github-actions bot force-pushed the refactor_rewrite_and_cleanup branch from 3c89cb9 to 33a3115 Compare May 9, 2025 17:32
@vaccel-bot vaccel-bot bot added ok-to-test and removed ok-to-test labels May 9, 2025
@ananos ananos merged commit 70d2e93 into main May 9, 2025
23 of 24 checks passed
ananos pushed a commit that referenced this pull request May 9, 2025
@papazof @ananos
refactor: Rewrite modules and improve build
3d11387 
Rewrite package modules, cleanup and modernize build process:
- Move all configuration but `cffi`'s build trigger to `pyproject.toml`
- Rewrite build script for `cffi` to auto-generate bindings from the
  `vaccel.h` header
- Configure `setuptools` to build an `abi3` wheel (compatible with all
  Python versions >= 3.10)
- Add `CType` abstract class to provide a common interface for C types
- Implement wrappers based on `CType` for built-in Python types
- Refactor and improve `vaccel` components based on `CType`
- Rewrite `vaccel` operations as `Session` mixins
- Update/extend tests and provide common `pytest` setup for environment
  variables and vaccel paths through `pkg-config`
- Add a `classify` example with similar functionality to the C vaccel
  example
- Improve and extend docstrings
- Cleanup redundant files and code

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
ananos pushed a commit that referenced this pull request May 9, 2025
@papazof @ananos
feat: Add TFLite and Torch operations
cb62dfc 
Add API support for `TFLite` and `Torch` operations and relevant tests

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
ananos pushed a commit that referenced this pull request May 9, 2025
@papazof @ananos
refactor: Move operations to ops
accc1a2 
Move all operation mixins to the `ops` subpackage, mirroring the vaccel
C code structure

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
ananos pushed a commit that referenced this pull request May 9, 2025
@papazof @ananos
chore: Add license files and headers
59d87ed 
Add `LICENSE`, `NOTICE` and license headers to files

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
ananos pushed a commit that referenced this pull request May 9, 2025
@papazof @ananos
ci: Rewrite workflows based on the vaccel repo
7db27e0 
Rewrite workflows based on the vaccel repo actions and move docs
generation to `nubificus/vaccel-docs`

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
ananos pushed a commit that referenced this pull request May 9, 2025
@papazof @ananos
build: Add script to run examples
b29d1b8 
Add a `run-examples.py` script to run the examples with sample inputs
and configure the CI to use it

PR: #16
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@ananos ananos deleted the refactor_rewrite_and_cleanup branch May 9, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ananos ananos ananos approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@papazof @ananos