Skip to content

[PWGEM] Please consider the following formatting changes to #11694 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nstrangm merged 1 commit into from
Jun 19, 2025
Merged

[PWGEM] Please consider the following formatting changes to #11694 #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions PWGEM/PhotonMeson/Tasks/emcalBcWiseGammaGamma.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2025 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGEM/PhotonMeson/Tasks/emcalBcWiseGammaGamma.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Provide mandatory file documentation.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -15,22 +15,22 @@
/// \brief Task that extracts pi0s from BC wise derived data of EMCal clusters
///
/// \author Nicolas Strangmann (nicolas.strangmann@cern.ch) Goethe University Frankfurt
///

Check failure on line 18 in PWGEM/PhotonMeson/Tasks/emcalBcWiseGammaGamma.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \file is missing, incorrect or misplaced.

#include "Framework/runDataProcessing.h"
#include "PWGEM/PhotonMeson/DataModel/bcWiseTables.h"

#include "CommonConstants/MathConstants.h"
#include "EMCALBase/Geometry.h"
#include "Framework/AnalysisTask.h"
#include "Framework/HistogramRegistry.h"
#include "Framework/runDataProcessing.h"

#include "TString.h"
#include "Math/Vector4D.h"
#include "Math/Vector3D.h"
#include "Math/AxisAngle.h"
#include "Math/LorentzRotation.h"
#include "Math/Rotation3D.h"
#include "Math/AxisAngle.h"

#include "CommonConstants/MathConstants.h"
#include "EMCALBase/Geometry.h"
#include "PWGEM/PhotonMeson/DataModel/bcWiseTables.h"
#include "Math/Vector3D.h"
#include "Math/Vector4D.h"
#include "TString.h"

using namespace o2;
using namespace o2::framework;
Expand Down Expand Up @@ -132,7 +132,7 @@
mHistManager.fill(HIST("Event/nBCs"), 0, bc.centrality());
float mu = bc.mu();
mHistManager.fill(HIST("Event/Mu"), mu);
double p = mu > 0.001 ? mu / (1 - std::exp(-mu)) : 1.; // No pile-up for small mu (protection against division by zero)

Check failure on line 135 in PWGEM/PhotonMeson/Tasks/emcalBcWiseGammaGamma.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
mHistManager.fill(HIST("Event/nCollisions"), 0, bc.centrality(), p);
if (bc.hasFT0()) {
mHistManager.fill(HIST("Event/nBCs"), 1, bc.centrality());
Expand All @@ -159,7 +159,7 @@
mHistManager.fill(HIST("Event/CentralityVsAmplitude"), bc.centrality(), bc.ft0Amplitude());

mHistManager.fill(HIST("Event/nCollPerBC"), collisions.size(), bc.centrality());
if (collisions.size() == 2) {

Check failure on line 162 in PWGEM/PhotonMeson/Tasks/emcalBcWiseGammaGamma.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
mHistManager.fill(HIST("Event/Z1VsZ2"), collisions.iteratorAt(0).zVtx(), collisions.iteratorAt(1).zVtx());
mHistManager.fill(HIST("Event/dZ"), collisions.iteratorAt(0).zVtx() - collisions.iteratorAt(1).zVtx());
}
Expand Down Expand Up @@ -192,7 +192,7 @@

mHistManager.fill(HIST("GG/invMassVsPt"), v12.M(), v12.Pt(), bc.centrality());

if (clusters.size() < 3)

Check failure on line 195 in PWGEM/PhotonMeson/Tasks/emcalBcWiseGammaGamma.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;

if (bc.globalIndex() % cfgBGEventDownsampling != 0)
Expand All @@ -202,7 +202,7 @@

ROOT::Math::AxisAngle rotationAxis(v12.Vect(), constants::math::PIHalf);
ROOT::Math::Rotation3D rotationMatrix(rotationAxis);
for (ROOT::Math::PtEtaPhiMVector vi : {v1, v2}) {

Check failure on line 205 in PWGEM/PhotonMeson/Tasks/emcalBcWiseGammaGamma.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.

vi = rotationMatrix * vi;

Expand Down Expand Up @@ -266,7 +266,7 @@
return false;
if (cfgSelectOnlyUniqueAmbiguous == 1 && collisions.size() != 1)
return false;
if (cfgSelectOnlyUniqueAmbiguous == 2 && collisions.size() == 1)

Check failure on line 269 in PWGEM/PhotonMeson/Tasks/emcalBcWiseGammaGamma.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
return true;
}
Expand Down
Loading