storage: Support RANGE streaming and use it in Object service #3776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3776 +/- ##
==========================================
+ Coverage 25.60% 25.65% +0.04%
==========================================
Files 657 657
Lines 42097 42117 +20
==========================================
+ Hits 10780 10805 +25
+ Misses 30338 30335 -3
+ Partials 979 977 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
storage-range-stream
branch
4 times, most recently
from
a612124 to
6135140
Compare
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
cthulhu-rider
force-pushed
the
storage-range-stream
branch
2 times, most recently
from
f662d03 to
893af9a
Compare
cthulhu-rider
force-pushed
the
storage-range-stream
branch
from
893af9a to
1f281f3
Compare
Previously, buffer to copy local part into could theoretically be unallocated, leaving the part after `copy()` uninitialized. This could lead to a false-negative recovery when exactly one part was missing. Refs #3554. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previous GetRange() implementation opened stream and read data into buffer allocated in place. Stream opening may now be done via GetRangeStream(). GetRange() of lower components (Shard, FSTree) are dropped as no longer used. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
storage-range-stream
branch
from
1f281f3 to
b17a546
Compare
carpawell
approved these changes
Jan 16, 2026
|
|
||
| if off > math.MaxInt64 || ln > math.MaxInt64 { // 8 exabytes, amply | ||
| stream.Close() | ||
| return nil, fmt.Errorf("range overflowing int64 is not supported by this server: off=%d,len=%d", off, ln) |
Member
There was a problem hiding this comment.
why this is not func's arg then?
|
|
||
| if e.blockErr != nil { | ||
| return nil, e.blockErr | ||
| stream, err := e.getRangeStream(addr, offset, length) |
Member
There was a problem hiding this comment.
is it ok that all the code below can be executed, despite any changes to e.blockMtx now?
Member
There was a problem hiding this comment.
Shouldn't be a problem to me, it doesn't depend on engine state.
roman-khimov
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3593. Refs #3439.