storage: Sync shard sorting when writing and reading EC parts #3773
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
ec-shard-sort
branch
2 times, most recently
from
6eb5f75 to
7ed43b4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3773 +/- ##
=======================================
Coverage 25.60% 25.60%
=======================================
Files 657 657
Lines 42102 42107 +5
=======================================
+ Hits 10779 10781 +2
- Misses 30344 30347 +3
Partials 979 979 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
cthulhu-rider
force-pushed
the
ec-shard-sort
branch
from
7ed43b4 to
230dac4
Compare
Previously, shards were sorted by parent address on writing and by part address on reading. This generally led to suboptimal traversal of shards on reading causing unavoidable misses. To prevent this, selection algorithms must be synchronized. This makes `StorageEngine.Put()` to sort shards by parent ID when EC part is being written. Closes #3537. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
ec-shard-sort
branch
from
230dac4 to
476652b
Compare
roman-khimov
approved these changes
Jan 14, 2026
carpawell
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.