Container attributes #3733
Merged
Container attributes #3733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
container-attributes
branch
from
a28ae50 to
1abb88b
Compare
cthulhu-rider
force-pushed
the
container-attributes
branch
6 times, most recently
from
d136d4e to
257168b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3733 +/- ##
==========================================
- Coverage 26.13% 25.88% -0.26%
==========================================
Files 658 660 +2
Lines 41777 42213 +436
==========================================
+ Hits 10919 10927 +8
- Misses 29856 30285 +429
+ Partials 1002 1001 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
container-attributes
branch
2 times, most recently
from
e0d6ff2 to
303fea6
Compare
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
Member
|
Is #3728 obsolete with this? |
cthulhu-rider
force-pushed
the
container-attributes
branch
3 times, most recently
from
b579875 to
87e636f
Compare
Member
|
Conflicts now. |
cthulhu-rider
force-pushed
the
container-attributes
branch
from
87e636f to
e786a2f
Compare
cthulhu-rider
force-pushed
the
container-attributes
branch
from
e786a2f to
99d2893
Compare
roman-khimov
approved these changes
Dec 25, 2025
carpawell
approved these changes
Dec 25, 2025
| var tokV2 sessionv2.Token | ||
| err = tokV2.Unmarshal(v.binTokenSession) | ||
| if err == nil { | ||
| // TODO |
Contributor
Author
There was a problem hiding this comment.
conflicting area, will definitely know
| acc = notary.FakeContractAccount(mainTx.Signers[2].Account) | ||
| } else { | ||
| pubBytes, ok := vm.ParseSignatureContract(script) | ||
| pubBytes, ok := scparser.ParseSignatureContract(script) |
Member
There was a problem hiding this comment.
It's related to neo-go update
Member
There was a problem hiding this comment.
i understand, i meant updating neo-go with fixes in a separate commit
Contributor
Author
There was a problem hiding this comment.
i dont need the update on its own, it came automatically
cthulhu-rider
force-pushed
the
container-attributes
branch
from
99d2893 to
4c376da
Compare
Support nspcc-dev/neofs-contract#564. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Support nspcc-dev/neofs-contract#564, nspcc-dev/neofs-api#360. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Follow nspcc-dev/neofs-api#360. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
container-attributes
branch
from
4c376da to
0ddcf2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.