Skip to content

refactor: extract language-core#82

Merged
9romise merged 6 commits intomainfrom
core
Mar 17, 2026
Merged

refactor: extract language-core#82
9romise merged 6 commits intomainfrom
core

Conversation

@9romise
Copy link
Member

@9romise 9romise commented Mar 17, 2026

No description provided.

@9romise 9romise marked this pull request as ready for review March 17, 2026 14:05
@9romise 9romise added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit 20c9d73 Mar 17, 2026
11 checks passed
@9romise 9romise deleted the core branch March 17, 2026 14:19
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This pull request introduces a new packages/language-core package containing shared types, constants, and utility functions previously defined in the vscode extension. The package exports dependency extraction types, manifest information types, dependency resolution utilities, catalog handling, and package name formatting functions. The vscode extension is updated to import these shared exports rather than maintain local copies. Additionally, dependency type handling is refactored to introduce a DependencyInfo interface with methods, replacing the previous ResolvedDependencyInfo approach. Workflow files receive new build steps, and package.json scripts are updated from postinstall to prepare hooks.

Possibly related PRs

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description provided by the author, making it impossible to assess whether the description relates to the changeset. Add a pull request description explaining the purpose, rationale, and scope of the refactoring to extract the language-core package.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch core
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant