Skip to content

fix: remove unnecessary search landmark nested in <search> #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 2 commits into from
Jan 29, 2026
Merged

fix: remove unnecessary search landmark nested in <search> #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b288d5e
fix: remove unnecessary search landmark nested in `<search>`
knowler Jan 29, 2026
f16bdc1
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions app/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,7 @@ onKeyStroke(',', e => {
<div class="flex-1 flex items-center justify-center gap-4 sm:gap-6">
<!-- Search bar (shown on all pages except home and search) -->
<search v-if="showSearchBar" class="hidden sm:block flex-1 max-w-md">
<form
role="search"
method="GET"
action="/search"
class="relative"
@submit.prevent="handleSearchInput"
>
<form method="GET" action="/search" class="relative" @submit.prevent="handleSearchInput">
<label for="header-search" class="sr-only">
{{ $t('search.label') }}
</label>
Expand Down
8 changes: 1 addition & 7 deletions app/pages/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,7 @@ defineOgImageComponent('Default')
class="w-full max-w-xl motion-safe:animate-slide-up motion-safe:animate-fill-both"
style="animation-delay: 0.2s"
>
<form
role="search"
method="GET"
action="/search"
class="relative"
@submit.prevent="handleSearch"
>
<form method="GET" action="/search" class="relative" @submit.prevent="handleSearch">
<label for="home-search" class="sr-only">
{{ $t('search.label') }}
</label>
Expand Down
2 changes: 1 addition & 1 deletion app/pages/search.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ defineOgImageComponent('Default', {
<h1 class="font-mono text-xl sm:text-2xl font-medium mb-4">{{ $t('nav.search') }}</h1>

<search>
<form role="search" method="GET" action="/search" class="relative" @submit.prevent>
<form method="GET" action="/search" class="relative" @submit.prevent>
<label for="search-input" class="sr-only">{{ $t('search.label') }}</label>

<div class="relative group" :class="{ 'is-focused': isSearchFocused }">
Expand Down
Loading