feat: keep search box in header #313
Merged
+141
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
garthdw
force-pushed
the
feat/top-searchbox
branch
from
1f40bc9 to
598d5e5
Compare
Collaborator
|
might need to update the current search behaviour tests 🙏 |
garthdw
force-pushed
the
feat/top-searchbox
branch
from
598d5e5 to
0b0fdaa
Compare
danielroe
reviewed
Jan 29, 2026
tests/interactions.spec.ts
Outdated
Comment on lines
13
to
14
| // manually focus search | ||
| await searchInput.focus() |
Collaborator
There was a problem hiding this comment.
I think we want it to autofocus when the search page is opened.
Contributor
Author
There was a problem hiding this comment.
I have gone with autofocus on the search input.
I did start down a hacky approach to only focus when AppHeader is mounted and route is search. I can switch to that approach if we want it to only happen on the search page instead of any "first load" page.
garthdw
force-pushed
the
feat/top-searchbox
branch
from
3f94d66 to
402df59
Compare
Collaborator
|
we should think about mobile view too.... currently there's no search input on mobile might want to have a small input that goes full width when focused? |
Avoid taking up space for searchbox on search page. Mainly moved the query string watching from search.vue to AppHeader.vuue # Conflicts: # app/components/AppHeader.vue # app/pages/search.vue # Conflicts: # app/components/AppHeader.vue # app/pages/search.vue
Selected item was jumping when scrolling up because of focus. Hook to the up/down arrows on a document level instead of section level.
Improve search on mobile. Smaller search box that expands full width on click.
garthdw
force-pushed
the
feat/top-searchbox
branch
from
402df59 to
d2befa5
Compare
Contributor
Author
|
This is where I got to for mobile Screen.Recording.2026-01-29.at.21.55.29.mov |
Collaborator
|
looks perfect to me! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
# Conflicts: # app/pages/search.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid taking up space for searchbox on search page.
Mainly moved the query string watching from search.vue to AppHeader.vue
Closes #291
Screen.Recording.2026-01-29.at.17.43.18.mov