Skip to content

fix: avoid mismatch of selected language on hydration #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 4 commits into from
Jan 29, 2026
Merged

fix: avoid mismatch of selected language on hydration #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96f641a
fix(settings): wrong default selected language
MatteoGabriele Jan 29, 2026
47b34ed
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 29, 2026
2db3b78
refactor: use clientonly on select with skeleton
MatteoGabriele Jan 29, 2026
ed70356
Merge branch 'fix/settings-default-selected-language' of https://gith…
MatteoGabriele Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions app/pages/settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ defineOgImageComponent('Default', {
</div>
</section>

<!-- LANGUAGE Section -->
<section>
<h2 class="text-xs text-fg-subtle uppercase tracking-wider mb-4">
{{ $t('settings.sections.language') }}
Expand All @@ -214,16 +213,22 @@ defineOgImageComponent('Default', {
<label for="language-select" class="block text-sm text-fg font-medium">
{{ $t('settings.language') }}
</label>
<select
id="language-select"
:value="locale"
class="w-full sm:w-auto min-w-48 bg-bg border border-border rounded-md px-3 py-2 text-sm text-fg focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50 cursor-pointer"
@change="setLocale(($event.target as HTMLSelectElement).value as typeof locale)"
>
<option v-for="loc in availableLocales" :key="loc.code" :value="loc.code">
{{ loc.name }}
</option>
</select>

<ClientOnly>
<select
id="language-select"
:value="locale"
class="w-full sm:w-auto min-w-48 bg-bg border border-border rounded-md px-3 py-2 text-sm text-fg focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50 cursor-pointer"
@change="setLocale(($event.target as HTMLSelectElement).value as typeof locale)"
>
<option v-for="loc in availableLocales" :key="loc.code" :value="loc.code">
{{ loc.name }}
</option>
</select>
<template #fallback>
<span class="skeleton block w-48 h-8" />
</template>
</ClientOnly>
</div>

<!-- Translation helper for non-source locales -->
Expand Down
2 changes: 1 addition & 1 deletion lunaria/files/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@
},
"contributors": {
"title": "Contributors",
"description": "npmx is fully open source, built by an amazing community of contributors.",
"description": "npmx is fully open source, built by an amazing community of contributors. Join us and let's build the npm browsing experience we always wanted, together.",
"loading": "Loading contributors...",
"error": "Failed to load contributors",
"view_profile": "View {name}'s GitHub profile"
Expand Down