Skip to content

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Jan 29, 2026

follow-up #293
There is one condition I did not notice well. I think when the input field is empty, if we click on search button we can directly navigate to "/search". On that time we do not need debounce.

@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 29, 2026 3:07pm
npmx.dev Error Error Jan 29, 2026 3:07pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
npmx-lunaria Ignored Ignored Jan 29, 2026 3:07pm

Request Review

Copy link
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the bug? doesn't debouncedNavigate still navigate even if it's empty?

@iiio2
Copy link
Contributor Author

iiio2 commented Jan 29, 2026

@danielroe, I think it takes slightly more time after clicking on the search button. It may affect the UX. If we click on Search button, it should navigate immediately to "/search". The debounce may need to typing something in the input field. It should not take time when we click on the search button when input is empty.

@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@danielroe danielroe added this pull request to the merge queue Jan 29, 2026
Merged via the queue into npmx-dev:main with commit 1c87ded Jan 29, 2026
12 of 13 checks passed
@iiio2
Copy link
Contributor Author

iiio2 commented Jan 29, 2026

Thanks. 😊

@iiio2 iiio2 deleted the chore/ignore-debounce-for-empty-input branch January 29, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants