-
Notifications
You must be signed in to change notification settings - Fork 95
chore: ignore debounce for empty input #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ignore debounce for empty input #299
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
danielroe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the bug? doesn't debouncedNavigate still navigate even if it's empty?
|
@danielroe, I think it takes slightly more time after clicking on the search button. It may affect the UX. If we click on Search button, it should navigate immediately to "/search". The debounce may need to typing something in the input field. It should not take time when we click on the search button when input is empty. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Thanks. 😊 |
follow-up #293
There is one condition I did not notice well. I think when the input field is empty, if we click on search button we can directly navigate to "/search". On that time we do not need debounce.