Skip to content

feat: add standard site lexicons to project #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 9 commits into from
Jan 29, 2026
Merged

feat: add standard site lexicons to project #297

danielroe merged 9 commits into from
Jan 29, 2026
+547 −19

Conversation

@jonathanyeong
Copy link
Contributor

@jonathanyeong jonathanyeong commented Jan 29, 2026 •
edited
Loading

This PR pulls out the standard site lexicons generated in the setup blog PR just in case this was blocking @fatfingers23 and @zeucapua work.

@vercel
Copy link

vercel bot commented Jan 29, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 29, 2026 3:09pm
npmx.dev Ready Ready Preview, Comment Jan 29, 2026 3:09pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
npmx-lunaria Ignored Ignored Jan 29, 2026 3:09pm

Request Review

@jonathanyeong
feat: generate lexicons on postinstall & log out marshalling to stand…
9e1b579 
…ard site
@jonathanyeong
feat: commit lexicons
9fba72d 
It should be good to leave these in the project. We can generate new ones
as we go.
danielroe
danielroe reviewed Jan 29, 2026
View reviewed changes
shared/types/lexicons/site.ts Outdated
* THIS FILE WAS GENERATED BY "@atproto/lex". DO NOT EDIT.
*/

export * as standard from './site/standard.js'
Copy link
Collaborator

@danielroe danielroe Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to gitignore the generated files?

Copy link
Contributor Author

@jonathanyeong jonathanyeong Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fatfingers23 mentioned that it was okay to commit the generated types and we can generate new ones as we go. Might let Bailey chime in. I'm easy either way!

Copy link
Contributor

@fatfingers23 fatfingers23 Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good to. The lexicon schema files should be the source of truth and can generate types/clients from it in any language. Double checked the atproto repo and they're doing the same

https://github.com/bluesky-social/atproto/blob/main/packages/api/src/client/types/com/atproto/sync/getRepo.ts

Copy link
Contributor

@fatfingers23 fatfingers23 Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops sorry. I should of been more specific. We're good to leave the generated files in the project, it's what the Bluesky team and others do. But I also don't think it's bad if we remove the either and depend on the lex generation tool

@fatfingers23
Copy link
Contributor

fatfingers23 commented Jan 29, 2026

LGTM! And thank you for breaking those out. That does help.

@github-actions
Copy link

github-actions bot commented Jan 29, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

jonathanyeong
jonathanyeong commented Jan 29, 2026
View reviewed changes
lunaria/files/en-US.json
"contributors": {
"title": "Contributors",
"description": "npmx is fully open source, built by an amazing community of contributors.",
"description": "npmx is fully open source, built by an amazing community of contributors. Join us and let's build the npm browsing experience we always wanted, together.",
Copy link
Contributor Author

@jonathanyeong jonathanyeong Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielroe hmm not sure how this was pulled in 🤔.

@danielroe danielroe added this pull request to the merge queue Jan 29, 2026
Merged via the queue into npmx-dev:main with commit 183d7bc Jan 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

@zeucapua zeucapua Awaiting requested review from zeucapua

+1 more reviewer

@fatfingers23 fatfingers23 fatfingers23 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanyeong @fatfingers23 @danielroe