Skip to content

Conversation

@mikouaji
Copy link
Contributor

@mikouaji mikouaji commented Jan 29, 2026

Implements #265
Does not replace npmjs url without a path present

@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 29, 2026 8:37am
npmx.dev Ready Ready Preview, Comment Jan 29, 2026 8:37am
1 Skipped Deployment
Project Deployment Review Updated (UTC)
npmx-lunaria Ignored Ignored Preview Jan 29, 2026 8:37am

Request Review

@danielroe
Copy link
Collaborator

if we want to stay within the app, we need to do more than replace the URLs - we also need to handle clicks on them to use client-side routing.

we could add a click handler to the readme container, and listen for clicks on npmjs urls, instead. then normalise them to our format. if our router doesn't recognise url format, then we send it to npmjs instead.

@mikouaji
Copy link
Contributor Author

if we want to stay within the app, we need to do more than replace the URLs - we also need to handle clicks on them to use client-side routing.

we could add a click handler to the readme container, and listen for clicks on npmjs urls, instead. then normalise them to our format. if our router doesn't recognise url format, then we send it to npmjs instead.

I agree, solving it that way will be way better, will look into updating it in the evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants