Skip to content

fix(ui): fix github redirect external link #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabianbernhart wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ui): fix github redirect external link #2109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e5ffd7
fix(ui): strip trailing .git in useRepositoryUrl composable
Mar 16, 2026
ea1e3c1
test(nuxt): add useRepositoryUrl valid url test
Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/composables/useRepositoryUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ export function useRepositoryUrl(
let url = normalizeGitUrl(repo.url)

// append `repository.directory` for monorepo packages
if (repo.directory) {
url = joinURL(`${url}/tree/HEAD`, repo.directory)
if (repo.directory && url) {
url = joinURL(url.replace(/\.git$/, ''), `/tree/HEAD`, repo.directory)
Comment on lines +22 to +23
Copy link
Contributor

@MatteoGabriele MatteoGabriele Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move this directly into the normalizeGitUrl function in git-providers.ts, so it doesn't need to be repeated elsewhere.

}

return url
Expand Down
36 changes: 36 additions & 0 deletions test/nuxt/composables/use-repository-url.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import { describe, expect, it } from 'vitest'

const fakeRequestedVersion = (
data: Partial<SlimPackument['requestedVersion']>,
): SlimPackument['requestedVersion'] => {
return {
_id: 'any',
_npmVersion: 'idk',
dist: {
shasum: '',
signatures: [],
tarball: '',
},
name: 'any',
version: '0.0.1',
...data,
}
}

describe('useRepositoryUrl', () => {
it('should have valid github repository url', () => {
Copy link
Contributor

@MatteoGabriele MatteoGabriele Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add the test to the git-providers.spec.ts file

Copy link
Author

@fabianbernhart fabianbernhart Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i continue the pr or should i let bluwy handle it?

const test = fakeRequestedVersion({
repository: {
type: 'git',
url: 'git+https://github.com/nuxt/nuxt.git',
directory: 'packages/nuxt',
},
})

const result = useRepositoryUrl(test)

expect(result.repositoryUrl.value).toEqual(
'https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt',
)
})
})
Loading