Skip to content

chore: remove transitive string.prototype.matchall polyfill#2080

Open
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:no-polyfill
Open

chore: remove transitive string.prototype.matchall polyfill#2080
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:no-polyfill

Conversation

@gameroman
Copy link
Contributor

Testing my new thing

This should massively reduce dependency size without extra effort

@vercel
Copy link

vercel bot commented Mar 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Mar 15, 2026 1:27am
npmx.dev Ready Ready Preview, Comment Mar 15, 2026 1:27am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Mar 15, 2026 1:27am

Request Review

@gameroman gameroman changed the title fix: remove transitive string.prototype.matchall polyfill chore: remove transitive string.prototype.matchall polyfill Mar 15, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2026

📝 Walkthrough

Walkthrough

A pnpm workspace configuration override has been updated to include a new dependency mapping. The string.prototype.matchall package is now configured to use the no-polyfill variant version 0.0.1 from npm. The modification adds a single line to the override configuration without any other structural or logical changes.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description mentions testing and dependency size reduction, which aligns with the changelog showing an override for a polyfill package.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Revert "Remove transitive string.prototype.matchall polyfill and update lockfile"

This reverts commit 26667a5.

fix
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 466b3ce0-6fed-4a25-b9d5-446eb9c89c00

📥 Commits

Reviewing files that changed from the base of the PR and between 26667a5 and f0ae789.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

@gameroman
Copy link
Contributor Author

Maybe using nolyfill is better indeed

@gameroman gameroman marked this pull request as draft March 15, 2026 03:16
@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gameroman gameroman marked this pull request as ready for review March 15, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant