docs(ui): add dark theme for storybook docs#2062
docs(ui): add dark theme for storybook docs#2062cylewaitforit wants to merge 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughReplaces an in-file Storybook theme with a new module Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip Migrating from UI to YAML configuration.Use the |
|
@cylewaitforit theme switcher doesn't work on the welcome page :( In other parts lgtm |
@alexdln Good point, that could be pretty confusing. So definitely worth addressing. The theme switcher switches the theme for the story previews not for the "story manager". So on the welcome doc page it had nothing to switch because it isn't displaying any stories. While I'd love to get an What I did figure out was a way to say with tags that a particular docs page doesn't need to show the toolbar. 0d6dd3d Let me know if that seems like a viable solution for now. |
🔗 Linked issue
Related: #1964
🧭 Context
This adds the dark theme to the docs pages in the npmx storybook.
Note
Because there are not any component docs pages in the storybook currently, to view the canvas change with the theme selection, check the preview of #1964 where autodocs have been turned on for button stories.
https://698b88d5157d89f1f33a6c21-ieffcbxthf.chromatic.com/?path=/docs/components-button-buttonbase--docs
📚 Description
This allows the docs to be viewed with the default npmx theme and retains the theme switcher capabilities for the story canvas portion of the docs.