-
-
Notifications
You must be signed in to change notification settings - Fork 345
feat(ui): added word wrap to code viewer #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stephansama
wants to merge
7
commits into
npmx-dev:main
Choose a base branch
from
stephansama:feat/add-word-wrap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−2
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ca13cca
feat(word-wrap): added word wrap to code viewer
stephansama e64a6b5
chore: merge develop
stephansama 95848e8
chore: merge main
stephansama e14b94f
chore: made toggle icon switch between modes
stephansama c2108ea
chore: removed prettier formats
stephansama 1e3ed27
chore: addressed ai comments
stephansama 72c3c6e
chore: removed prettier formatting again :facepalm:
stephansama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 2129
Re-sync wrapped line heights after the viewer becomes visible.
The parent component mounts
CodeViewerwithv-show="!fileContent.markdownHtml || markdownViewMode === 'code'"and defaults to preview mode. For markdown files, this means the component is initially hidden (display: none), yet the immediate watcher on[props.selectedLines, props.html]fires during mount and callssyncLineHeights()while the viewer is not rendered. This causesoffsetHeightto return0, setting all line-number heights to0px. The heights are never corrected when the user switches to code view with word wrap enabled, leaving the line-number column collapsed.Add visibility detection to skip measurement while hidden, or use a
ResizeObserveron the rendered code block to continuously maintain synchronisation.🧰 Tools
🪛 Biome (2.4.6)
[error] 43-43: This callback passed to forEach() iterable method should not return a value.
(lint/suspicious/useIterableCallbackReturn)