feat: add dependents sorted by download #105
Draft
+244
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinnymac is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danielroe
reviewed
Jan 26, 2026
app/composables/useNpmRegistry.ts
Outdated
|
|
||
| // Use the existing searchNpmPackages with depends-on: query | ||
| // This finds packages that have `name` as a dependency | ||
| const response = await searchNpmPackages(`depends-on:${name}`, { size }) |
Collaborator
There was a problem hiding this comment.
I'm not sure this pulls in correct data:
Collaborator
There was a problem hiding this comment.
in e18e we have a whole other database to do this query because the npm one wasn't capable. so when i saw this, i was very surprised and hoped it was true so we could switch 😂
but im pretty sure the npm api doesn't do what you think here, or it does, but very poorly
Contributor
Author
There was a problem hiding this comment.
Darn, back to the drawing board! Thought the data was correct 🥲
Note: The data from /registry is stale currently, but is being refreshed. Work to add download counts to /live_registry is in progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dependents to package page sorted by most downloaded (top 50)
Closes #31