Skip to content

fix(arborist): fix dep flags and workspace edges in linked strategy #9101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
manzoorwanijk wants to merge 1 commit into
base: latest
Choose a base branch
from
+237 −400
Draft

fix(arborist): fix dep flags and workspace edges in linked strategy #9101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/commands/ls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,9 @@ const filterLinkedStrategyEdges = ({ node, currentDepth }) => {
)))

return (edge) => {
// Skip workspace edges for undeclared workspaces at root level
// Skip workspace edges for undeclared workspaces at root level.
// loadActual now creates in-memory Links for workspace targets so workspace edges should always resolve.
/* istanbul ignore next - defensive, workspace edges resolve via in-memory Links */
if (currentDepth === 0 && edge.type === 'workspace' && edge.missing) {
if (!declaredDeps.has(edge.name)) {
return false
Expand Down
Loading
Loading