Open
Conversation
Bumps [https-proxy-agent](https://github.com/TooTallNate/proxy-agents/tree/HEAD/packages/https-proxy-agent) from 7.0.6 to 8.0.0. - [Release notes](https://github.com/TooTallNate/proxy-agents/releases) - [Changelog](https://github.com/TooTallNate/proxy-agents/blob/main/packages/https-proxy-agent/CHANGELOG.md) - [Commits](https://github.com/TooTallNate/proxy-agents/commits/https-proxy-agent@8.0.0/packages/https-proxy-agent) --- updated-dependencies: - dependency-name: https-proxy-agent dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [agent-base](https://github.com/TooTallNate/proxy-agents/tree/HEAD/packages/agent-base) from 7.1.4 to 8.0.0. - [Release notes](https://github.com/TooTallNate/proxy-agents/releases) - [Changelog](https://github.com/TooTallNate/proxy-agents/blob/main/packages/agent-base/CHANGELOG.md) - [Commits](https://github.com/TooTallNate/proxy-agents/commits/agent-base@8.0.0/packages/agent-base) --- updated-dependencies: - dependency-name: agent-base dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [http-proxy-agent](https://github.com/TooTallNate/proxy-agents/tree/HEAD/packages/http-proxy-agent) from 7.0.2 to 8.0.0. - [Release notes](https://github.com/TooTallNate/proxy-agents/releases) - [Changelog](https://github.com/TooTallNate/proxy-agents/blob/main/packages/http-proxy-agent/CHANGELOG.md) - [Commits](https://github.com/TooTallNate/proxy-agents/commits/http-proxy-agent@8.0.0/packages/http-proxy-agent) --- updated-dependencies: - dependency-name: http-proxy-agent dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [socks-proxy-agent](https://github.com/TooTallNate/proxy-agents/tree/HEAD/packages/socks-proxy-agent) from 8.0.5 to 9.0.0. - [Release notes](https://github.com/TooTallNate/proxy-agents/releases) - [Changelog](https://github.com/TooTallNate/proxy-agents/blob/main/packages/socks-proxy-agent/CHANGELOG.md) - [Commits](https://github.com/TooTallNate/proxy-agents/commits/socks-proxy-agent@9.0.0/packages/socks-proxy-agent) --- updated-dependencies: - dependency-name: socks-proxy-agent dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of all the breaking change updates to the http agent libraries. There are two blockers here:
First, these packages do not have a default exports, so
requirewill no longer work. An issue has been opened seeing if one could be added. None of them do top level await so it should work just fine.The second problem is that the
socket errortest intest/agent.jsfails with an internal node traceback of anUnhandled error. Nothing in the underlying code changed in a way that would explain this. The most likely culprit is the way we are doing mocking of the underlyingsockslibrary.socks-proxy-agentis now usingimportand I don't know for sure ift.mockis going to catch that.This is a PR where we can follow the progress of the proxy-agents issue, and either wait till that update or refactor this package to export generator functions instead of bare classes. We also will need to figure out the mocking/testing error.