Skip to content

Sharedmvp #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nonebula wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Sharedmvp #9

nonebula wants to merge 44 commits into from

Conversation

@nonebula
Copy link
Owner

@nonebula nonebula commented Jul 16, 2024

No description provided.

Muhammad Mulla and others added 30 commits July 12, 2024 16:10
Tests
5da07f0
@nonebula
Merge pull request #6 from nonebula/playground
f98df9a 
Characters printing to board with name only
Tests
680da61
@nonebula
Added planning notes for today's actions
ad25235
Take2
8b7d7f5
Take 3
7aca382
@nonebula
Testing suite debugging
9be750e
@nonebula
Code for selecting character from gameboard added
569c5ea
@nonebula
GameLogic tweaked
d157660
@nonebula
Question handling refactored
abff432
Tests added
44b8c65
@nonebula
Merging conflicts
06490d1
@nonebula
Refactor attempted
30d7adf
@nonebula
Merge pull request #7 from nonebula/type-mismatch-debug
ddb3df2 
Refactor attempted
Team refactoring
3571f98
Initialisation tests
69c1f53
Handles questions test
8e7a773
Testing tests
3fcdfcf
BoardSpec hair colour test fixed
f856506
new tests added
151cb53
@nonebula
File cleanup
6fb9000
@nonebula
Added type to characters
9ad8fa4
@nonebula
Test refactor
6fd6ad8
@nonebula
Presentation notes
1496ec2
@nonebula
Moved one note to bottom of board
2679ef7
few changes
1764ed0
last commit
8e71f0a
@nonebula
Ext1 (#8)
de39d12 
* Terminal game prompts added

* Terminal game working and looping

---------

Co-authored-by: Joe Higgs <joe.higgs@mercator.group>
@nonebula
Minor styling
7002bba
@nonebula
Final touches
4507c39
AprilGar
AprilGar reviewed Jul 20, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 20, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 20, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 20, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 20, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 21, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 21, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 21, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 21, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 21, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 21, 2024
View reviewed changes
AprilGar
AprilGar reviewed Jul 21, 2024
View reviewed changes
@AprilGar
Copy link

AprilGar commented Jul 21, 2024

Well done team, this is a really great first attempt at a Scala project! We have things to work on, but I can see you have put a lot of thought into your project and the user experience. I can't wait to see how this and future projects progress as you get more comfortable with the language!
I also wanted to say well done on your demo, it was clear you had practised and it came across very well structured! I liked how you explained the future developments you hoped to include in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AprilGar AprilGar AprilGar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nonebula @AprilGar